Skip to content

Fix retrieval time of parent's Format when starting a subtest#157

Merged
frankban merged 1 commit intofrankban:masterfrom
dolmen-go:fix-Run-SetFormat
Jun 10, 2023
Merged

Fix retrieval time of parent's Format when starting a subtest#157
frankban merged 1 commit intofrankban:masterfrom
dolmen-go:fix-Run-SetFormat

Conversation

@dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 8, 2023

When starting a subtest, retrieve the parent Checker's Format synchronously before c.Run is called instead of when the test engine really starts running the subtest.

When starting a subtest, retrieve the parent Checker's Format
synchronously when c.Run is called instead of when the test engine
really starts running the subtest.
@dolmen dolmen force-pushed the fix-Run-SetFormat branch from cb5d72a to aeecb4c Compare June 10, 2023 07:05
Copy link
Owner

@frankban frankban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization, thanks!

@frankban frankban merged commit 821de06 into frankban:master Jun 10, 2023
@frankban
Copy link
Owner

frankban commented Aug 1, 2023

Released as v1.14.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants