Skip to content

fix: lint warnings#520

Merged
AlanFnz merged 6 commits intomainfrom
no_jira/fix-lint-warnings
Feb 25, 2025
Merged

fix: lint warnings#520
AlanFnz merged 6 commits intomainfrom
no_jira/fix-lint-warnings

Conversation

@AlanFnz
Copy link
Copy Markdown
Member

@AlanFnz AlanFnz commented Feb 24, 2025

What

This PR addresses and resolves the current warnings we are getting when running our linter

Why

Technical debt

How

It consists of:

  • Adding missing type annotations, mostly in stories
  • Removing unused imports
  • Removing alert from the experimental IconButton story in order to comply with the no-alert rule
  • Fix the placement property used in the Tooltip story
  • Use media query list obtained with evalColorSchemeQuery instead of the event's list in getCurrentScheme
    • This ensures the correct type (MediaQueryList) is passed and reflects the current state
  • Replace deprecated rules with their current equivalents in stylelint config

Comment thread src/components/ColorScheme/docs/CurrentScheme.tsx
Comment thread src/components/Tooltip/docs/Tooltip.stories.tsx
Copy link
Copy Markdown
Contributor

@shiba-codes shiba-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🚀

@AlanFnz AlanFnz merged commit 08ea4b8 into main Feb 25, 2025
@AlanFnz AlanFnz deleted the no_jira/fix-lint-warnings branch February 25, 2025 15:20
github-actions Bot pushed a commit that referenced this pull request Feb 25, 2025
### [2.26.1](v2.26.0...v2.26.1) (2025-02-25)

### Bug Fixes

* lint warnings ([#520](#520)) ([08ea4b8](08ea4b8))
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants