New secrets format based on Config::General for named connections.#23
Open
fozzmoo wants to merge 1 commit intofreeside:masterfrom
Open
New secrets format based on Config::General for named connections.#23fozzmoo wants to merge 1 commit intofreeside:masterfrom
fozzmoo wants to merge 1 commit intofreeside:masterfrom
Conversation
Owner
|
For reference: Please see: #17 (comment) |
Owner
|
No general technical issues with this change, but this is a significant plumbing change without any actual usage in the application itself. To merge into the open-source project (and thus ask everyone else to carry the maintenance and migration cost), we'd ask that you share a more complete change including the code changes which enable you to use read-only slaves effectively. t doesn't seem very fair of us to merge just the low-level ability to connect to different databases into master without also including the code to make useful use of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of a previous attempt to create readonly database handles. While the previous work provided for backwards compatibility for the current secrets file format, this does not. There is now new code in freeside-upgrade that migrates from the old format to the new Config::General-based format.