SPDX header migration and spacing fixes #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please double-check especially the SPDX changes, was quite a bit of manual work. |
Member
|
Doing any work in ebtables-tiny is probably not worth the effort, as we're going to drop it after the next release anyways (as soon as nftables is ready, which I intend to take care of) |
neocturne
reviewed
Apr 9, 2025
T-X
force-pushed
the
pr-style-spdx-tabs
branch
2 times, most recently
from
33950e5 to
f77fa1b
Compare
This migrates most of the packages to SPDX license headers. Also in preparation to make the "editorconfig-checker" linter happy, which doesn't like the spaces. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Contributor
Author
|
Changelog v2:
|
neocturne
reviewed
Apr 11, 2025
Contributor
Author
|
Changelog v3:
|
This for one thing converts spaces to tabs in C code. For another changes multi-line comments to the Linux kernel style where editorconfig-checker would complain. Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Contributor
Author
|
Changelog v4:
|
neocturne
requested changes
Apr 24, 2025
The .editorconfig file is a 1:1 copy from the main Gluon repository.
For the .editorconfig-checker.json the following customizations were
applied:
1) Changing SpacesAfterTabs from false to true: To allow the common Linux
kernel coding style which prefers tabs and then using spaces for a final
alignment. This silences the following three outputs:
```
admin/autoupdater/src/manifest.c:
33-34: Wrong indentation type(spaces instead of tabs)
net/respondd/src/respondd.c:
430: Wrong indentation type(spaces instead of tabs)
518: Wrong indentation type(spaces instead of tabs)
net/wgpeerselector/files/usr/bin/wgpeerselector:
199: Wrong indentation type(spaces instead of tabs)
291: Wrong indentation type(spaces instead of tabs)
```
2) Excluding net/ebtables-tiny and net/respondd/src/miniz.c. These are
basically code copies from another project. Keep their alignment to what
their upstream has. Also ebtables-tiny will be removed soon anyway with
the switch to nftables.
3) Excluding README.md files: editorconfig-checker complains especially
about their inline code blocks. I don't see an easy way to fix that, so
exclude README.md files for now.
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Check editorconfig-checker from the Github CI. Basically from this example workflow, with minor adjustments: https://github.com/editorconfig-checker/action-editorconfig-checker?tab=readme-ov-file#example-workflow Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Contributor
Author
|
Changelog v5:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to make the editorconfig-checker happy this performs the following style changes:
For one thing, use SPDX headers. editorconfig-checker does not like the spaces in these C files. For another, use tabs instead of spaces in various C files.
Still ToDo, to make editorconfig-checker succeed: