Fixed warnings about not removable non-empty folders in apt_clean()#16
Merged
domcleal merged 1 commit intofreight-team:masterfrom Mar 10, 2016
Merged
Fixed warnings about not removable non-empty folders in apt_clean()#16domcleal merged 1 commit intofreight-team:masterfrom
domcleal merged 1 commit intofreight-team:masterfrom
Conversation
lib/freight/apt.sh
Outdated
| apt_clean() { | ||
| find "$VARCACHE/pool" -links 1 -delete || true | ||
| find "$VARCACHE/pool" -links 1 -type f -delete | ||
| find "$VARCACHE/pool" -links 1 -type d -empty -delete |
There was a problem hiding this comment.
-links 1 should probably be removed from this search, I don't think it's too applicable for a dir.
|
👍 looks good otherwise. @mmoll you mentioned about Linux/GNUisms the other day, is |
|
@domcleal this is perfectly fine, as there are already a whole lot of these and the only way at the moment is to install findutils and coreutils as packages and use the respective binaries with g/gnu prefix (which is also perfectly normal to do for an FreeBSD package to patch these prefixes in). @Yrrsinn could you squash the commits together into one and force-push? |
|
👍 |
Author
|
@mmoll squashed and rebased ~ ready on my side |
Member
|
👍 |
domcleal
added a commit
that referenced
this pull request
Mar 10, 2016
Fixed warnings about not removable non-empty folders in apt_clean()
|
Thanks @Yrrsinn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freight-cache produces multiple lines warnings (proportional to the size of cache):
find: cannot delete [...]/cache/pool/[...]: Directory not emptyThe behavior is correct. This directories should only be removed, when they are empty after removing old packages. Thus the warnings are erroneous.