Skip to content

Conversation

@finnhartshorn
Copy link

Adds support for adding, deleting and listing DNS rewrite rules via the Adguard Home API

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (b72f80b) to head (a4bf244).
⚠️ Report is 1431 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   99.10%   99.17%   +0.06%     
==========================================
  Files           8        9       +1     
  Lines         224      242      +18     
==========================================
+ Hits          222      240      +18     
  Misses          2        2              
Flag Coverage Δ
unittests 99.17% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mr-awk
Copy link

mr-awk commented Sep 14, 2020

Would totally love this PR! I'm missing this today with my puppet and fabric management of the environment here home.

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 11, 2021
Base automatically changed from master to main March 11, 2021 14:51
@github-actions github-actions bot closed this Mar 19, 2021
@frenck frenck reopened this Mar 19, 2021
@frenck frenck added no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Mar 19, 2021
@copart
Copy link

copart commented Oct 23, 2022

I vote for this merge. I did have to modify the three requests in rewrite.py to self._adguard.request. Would submit a pull request, but would rather @finnhartshorn get the credit for the contribution.

@frenck frenck added the new-feature New features or options. label Nov 15, 2025
Copy link
Owner

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @finnhartshorn 👋

Can we see if we can revive this one and move it forward? 🙏

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck marked this pull request as draft November 15, 2025 12:04
Copilot AI review requested due to automatic review settings November 19, 2025 22:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for managing DNS rewrite rules through the AdGuard Home API, implementing list, add, and delete operations.

Key changes:

  • New AdGuardHomeRewrite class providing DNS rewrite rule management functionality
  • Complete test suite covering list, add, and delete operations including error cases
  • API endpoints for /control/rewrite/list, /control/rewrite/add, and /control/rewrite/delete

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
src/adguardhome/rewrite.py Implements the AdGuardHomeRewrite class with methods to list, add, and delete DNS rewrite rules
tests/test_rewrite.py Comprehensive test coverage for all rewrite operations including error handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

finnhartshorn and others added 2 commits November 20, 2025 09:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 19, 2025 23:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 20, 2025 00:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 20, 2025 00:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 20, 2025 00:47
@finnhartshorn finnhartshorn marked this pull request as ready for review November 20, 2025 00:48
@finnhartshorn finnhartshorn requested a review from frenck November 20, 2025 00:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@finnhartshorn
Copy link
Author

Hey @frenck,
All checks are passing and I've also done some manual testing on my local install, so should be good to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New features or options. no-stale This issue or PR is exempted from the stable bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants