-
-
Notifications
You must be signed in to change notification settings - Fork 39
Added support for the DNS rewrite rules AdGuard API #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 99.10% 99.17% +0.06%
==========================================
Files 8 9 +1
Lines 224 242 +18
==========================================
+ Hits 222 240 +18
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would totally love this PR! I'm missing this today with my puppet and fabric management of the environment here home. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I vote for this merge. I did have to modify the three requests in rewrite.py to self._adguard.request. Would submit a pull request, but would rather @finnhartshorn get the credit for the contribution. |
frenck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @finnhartshorn 👋
Can we see if we can revive this one and move it forward? 🙏
../Frenck
Blogging my personal ramblings at frenck.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for managing DNS rewrite rules through the AdGuard Home API, implementing list, add, and delete operations.
Key changes:
- New
AdGuardHomeRewriteclass providing DNS rewrite rule management functionality - Complete test suite covering list, add, and delete operations including error cases
- API endpoints for
/control/rewrite/list,/control/rewrite/add, and/control/rewrite/delete
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/adguardhome/rewrite.py | Implements the AdGuardHomeRewrite class with methods to list, add, and delete DNS rewrite rules |
| tests/test_rewrite.py | Comprehensive test coverage for all rewrite operations including error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…urn a list, dict or raw text response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @frenck, |
Adds support for adding, deleting and listing DNS rewrite rules via the Adguard Home API