Add client resources

[offbyone]

• added getters for the list of client / autoclient / supported tags resources

---

Proposed Changes

Adding support for the Client / AutoClient resources in AdGuard Home

The first commit here is to open discussion on structure and naming; if this is desirable in this state, I will add the update operations to it as well.

I don't intend to get super clever with remote ORM stuff here; I only want to have simple "add", "update", "delete" methods for them that refer to the APIs directly.

Related Issues

(Github link to related issues or pull requests)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[bendalton]

I'll ping too. Please test/merge this. I'd like to use it upstream with HomeAssistant

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[frenck]

I'll ping too. Please test/merge this. I'd like to use it upstream with HomeAssistant

I hate to bring it to you, but if you goal is to use this in Home Assistant: You can't.

To make this possible, we need an identifier. A request for this is open @ the AdGuard Home team.

So, if that is your only goal, I suggest closing this PR as it has no foreseeing future.

[offbyone]

Nope, I'm using this for scripting independent of HA.

[frenck]

Sorry I now realize I responded to a non-author, sorry about that 👍

../Frenck

[offbyone]

Okay; I'll add update methods here as well and then update the PR. Thanks.

[offbyone]

I'm still interested in merging this, just haven't had the time to finish it up.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

[offbyone]

I am still interested in merging this, I just need the maintainer to okay it.

[offbyone]

@frenck if you are not interested in maintaining this -- and that's entirely fair! -- how about discussing handing it off? I'm interested and willing.

[frenck]

@frenck if you are not interested in maintaining this

I am, sorry. I don't see the use case for Home Assistant in this regard (which is the primary use of this library).

how about discussing handing it off?

Because I haven't merged your itch? 🤷 Sorry, nope.

[offbyone]

So, for clarity, this isn't a "Python" adguard client, it is a home assistant adguard client library that happens to be written in Python?

[frenck]

From the readme:

There is my main use case. Right now, I'm drinking a few beers, so not going to dive in. I can try to make some time tomorrow morning.

../Frenck

[offbyone]

Mostly I'd like to know if this is considered a general purpose client library for the Adguard API, with features that are usable outside of HA, or if additions will purely be considered in the context of whether they are usable for HA. I've got some decisions to make about how I use it depending on that. The README indicates that home assistant is an example of an integration, not the only one that matters. Can you clarify please?

[Copilot]

Pull Request Overview

This PR adds support for AdGuard Home Client resources, enabling retrieval of automatically discovered clients (AutoClients), manually configured clients (Clients), and supported tags through a new Clients resource facade.

• Introduces three dataclasses (WhoisInfo, AutoClient, Client) to represent client data structures
• Adds a Clients resource facade with methods to fetch auto clients, configured clients, and supported tags
• Integrates the Clients resource into the main AdGuardHome class

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 17 comments.

File	Description
src/adguardhome/client.py	Implements the new Clients resource facade with dataclasses and methods for retrieving client information from the AdGuard Home API
src/adguardhome/adguardhome.py	Adds a clients property to the AdGuardHome class for accessing the Clients resource
tests/test_client.py	Provides comprehensive test coverage for the new client resource methods including empty lists, auto clients, and configured clients

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[frenck]

Alright, let's move this one forward.

However, the are some issues raised by the Copilot review and by the CI (which is failing).

Could you take a look?

../Frenck

                       

Blogging my personal ramblings at frenck.dev

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 16 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Import of 'Mapping' is not used.

Suggested change

	from typing import TYPE_CHECKING, Any, Mapping
	from typing import TYPE_CHECKING, Any

[offbyone]

Just saw this in the morass of notifications; I've addressed the changes. I elected not to rebase on top of main in order to avoid patch churn. Hopefully this works.