Conversation
wilwade
requested review from
a team,
JoeCap08055,
aramikm,
claireclark1,
enddynayn,
jeanettedepatie,
mattheworris,
p5150j and
shannonwells
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
25 tasks
shannonwells
requested changes
May 13, 2024
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
Questions and suggested changes
pallets/schemas/README.md
Outdated
| | ----------------------------------------------------------------------------------------------------- | ----------------------------------------------- | ------- | ---------------------------------------------------------------------------------------------------------------------------------------- | ------------- | | ||
| | `set_max_schema_model_bytes`<br />Governance action to alter the maximum byte length of Schema models | Governance | Tokens | [`SchemaMaxSizeChanged`](https://frequency-chain.github.io/frequency/pallet_schemas/pallet/enum.Event.html#variant.SchemaMaxSizeChanged) | 1 | | ||
| | `propose_to_create_schema_v2`<br />Creates a Council proposal a new schema to the Frequency Council | Token Account | Tokens | [`Proposed`](https://paritytech.github.io/polkadot-sdk/master/pallet_collective/pallet/enum.Event.html#variant.Proposed) | 66 | | ||
| | `create_schema_via_governance_v2`<br />Governance called version of `create_schema_v3` | Frequency Council | Tokens | [`SchemaCreated`](https://frequency-chain.github.io/frequency/pallet_schemas/pallet/enum.Event.html#variant.SchemaCreated) | 66 | |
Collaborator
There was a problem hiding this comment.
I'm not sure how else to word this but it's awkward and unclear. At any rate if you left it, it should be "Governance-called"
Collaborator
Author
There was a problem hiding this comment.
I had trouble with it as well. Swapped to Governance action like the set_max_schema_model_bytes has. How does that work?
Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com>
JoeCap08055
reviewed
May 14, 2024
JoeCap08055
reviewed
May 14, 2024
JoeCap08055
approved these changes
May 15, 2024
shannonwells
added a commit
that referenced
this pull request
May 16, 2024
# Goal The goal of this PR is to improve the documentation of the Pallets and make that documentation be able to be used on docs.frequency.xyz. Part of frequency-chain/docs#59 # Discussion - Schemas Pallet --------- Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to improve the documentation of the Pallets and make that documentation be able to be used on docs.frequency.xyz.
Part of frequency-chain/docs#59
Discussion