Conversation
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
wilwade
requested review from
a team,
JoeCap08055,
aramikm,
claireclark1,
enddynayn,
jeanettedepatie,
mattheworris and
shannonwells
and removed request for
a team
claireclark1
reviewed
Jun 4, 2024
claireclark1
reviewed
Jun 4, 2024
claireclark1
reviewed
Jun 4, 2024
claireclark1
reviewed
Jun 4, 2024
claireclark1
reviewed
Jun 4, 2024
JoeCap08055
reviewed
Jun 4, 2024
JoeCap08055
reviewed
Jun 4, 2024
JoeCap08055
reviewed
Jun 4, 2024
JoeCap08055
reviewed
Jun 4, 2024
Co-authored-by: V. Claire Olmstead <43625033+claireolmstead@users.noreply.github.com> Co-authored-by: Joe Caputo <joseph.caputo@unfinished.com>
shannonwells
approved these changes
Jun 5, 2024
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
Given the current version of this, I don't have anything blocking; I think it's clear enough but if you want to wordsmith it a little more, IMO it's up to you.
JoeCap08055
approved these changes
Jun 5, 2024
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
Some open comments, but I agree with @shannonwells--feel free to wordsmith some more, but this is a good improvement.
wilwade
commented
Jun 5, 2024
wilwade
commented
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to improve the documentation of the Pallets and make that documentation be able to be used on docs.frequency.xyz.
Part of frequency-chain/docs#59
Discussion
Screenshot