[CHORE] Update Frequency to v0.9.30 by saraswatpuneet · Pull Request #744 · frequency-chain/frequency

saraswatpuneet · 2022-12-05T16:10:50Z

Goal

The goal of this PR is to upgrade substrate to polkadot release .9.30

Closes paritytech/substrate#704

Notes:

PR for Substrate upgrade to 0.9.30
Release Notes

Major updates from 0.9.29 to 0.9.30:

Only breaking changes: Rename of Enums in Pallet Config
Call -> RuntimeCall
Event -> RuntimeEvent and
Origin -> RuntimeOrigin .
Here is the PR BREAKING: Rename Call & Event paritytech/substrate#11981
Upgrades from Polkadot v0.9.29 to v0.9.30, version update in dependencies tree
Weights update: V2 is slowly getting released and benign updates carried in this PR. The rest of the way to Weights V2 (Tracking Issue) paritytech/polkadot-sdk#256 and Add storage size component to weights paritytech/substrate#12277
@enddynayn @shannonwells some updates in vesting pallet Vesting pallet - make WithdrawReasons configurable paritytech/substrate#12109
@wilwade some pubsub stuff rpc: Implement transaction RPC API paritytech/substrate#12328
@wilwade Enable collation via RPC relay chain node paritytech/cumulus#1585
@shannonwells some updates in Democracy Bound uses of Call paritytech/substrate#11649

Checklist

demisx · 2022-12-05T19:29:35Z

Per my Slack message, I recommend test running all 3 CI workflows before merging #744 to main, so there are now surprises later. Let me know if you need my help with it when you are ready to merge.

shannonwells

It's a nitpick, but it would help with reviewing if you could summarize the changes involved in the upgrade, so I can know what to expect and review more efficiently. There was a lot of renaming involved, it looks like, as well as some parameter additions and reordering in cumulus.

shannonwells · 2022-12-05T20:58:13Z

node/cli/src/command.rs

 					cmd.run(partials.client)
 				}),
+				#[cfg(not(feature = "runtime-benchmarks"))]
+				frame_benchmarking_cli::BenchmarkCmd::Storage(_) =>


Is this required for the upgrade to v0.9.30?

It was a possible panic when someone was running storage benchmarks without the flags, but since template node has updated it so has others

shannonwells · 2022-12-05T20:59:20Z

node/service/src/service.rs

 	let transaction_pool = params.transaction_pool.clone();
 	let import_queue = cumulus_client_service::SharedImportQueue::new(params.import_queue);
-	let (network, system_rpc_tx, start_network) =
+	let (network, system_rpc_tx, tx_handler_controller, start_network) =


Nit: If these parameter changes are part of the update it would be nice to note it. I would prefer not to assume so.

Yes these are changes in the underlying apis

This update is interesting its a step towards separating collator with embedded relay paritytech/cumulus#1585

shannonwells · 2022-12-05T21:04:22Z

pallets/schemas/src/lib.rs

 	pub trait Config: frame_system::Config {
 		/// The overarching event type.
-		type Event: From<Event<Self>> + IsType<<Self as frame_system::Config>::Event>;
+		type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;


Was this also renamed in the new substrate version?

https://github.com/substrate-developer-hub/substrate-parachain-template/pull/133

codecov · 2022-12-05T21:11:17Z

Codecov Report

Merging #744 (ed504d7) into main (2c39942) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     paritytech/substrate#744   +/-   ##
=======================================
  Coverage   79.58%   79.58%           
=======================================
  Files          19       19           
  Lines         823      823           
=======================================
  Hits          655      655           
  Misses        168      168

Impacted Files	Coverage Δ
pallets/messages/src/lib.rs	`86.81% <ø> (ø)`
pallets/msa/src/lib.rs	`84.22% <ø> (ø)`
pallets/schemas/src/lib.rs	`80.00% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…requency into chore/upgrade_0.9.32

aramikm

Added some questions but overall looks good.
In Rust compiler We Trust

.github/workflows/merge-pr.yml

aramikm · 2022-12-06T00:41:45Z

integration-tests/package.json

    "license": "Apache-2.0",
    "dependencies": {
-        "@frequency-chain/api-augment": "v0.9.29",
+        "@frequency-chain/api-augment": "v0.9.30",


how is this going to affect metadata for other libraries?

I think exacting the version might complicate this we should do "^v0.9.29" for now given I am not sure at what stage these tests are run but for sure npm wont have this version till we release

demisx

Should each "Checklist" item of this PR needs to be checked off?

.github/workflows/verify-pr-commit.yml

wilwade

Only one thing that squeaked in that must change, but a few other questions and I think we want to run benchmarks before merging.

wilwade · 2022-12-13T13:04:30Z

integration-tests/package.json

+        "@frequency-chain/api-augment": "^v0.9.29",
+        "@polkadot/api": "^9.6.2",
+        "@polkadot/types": "^9.6.2",
+        "@polkadot/util": "^8.7.1",


This looks like a reversion.

I did this to pin the version on which integration tests run fine

I see yes something updated since this PR let me keep whats in main

node/service/src/service.rs

wilwade · 2022-12-13T13:09:38Z

node/service/src/service.rs

 								)
 							})?;
-							Ok((time, slot, parachain_inherent))
+							Ok((slot, timestamp, parachain_inherent))


These order swaps worry me. It feels like a mistake.

Yes this is change observed in the way they have modified starting node due to upcoming changes

Here is a boilerplate PR https://github.com/substrate-developer-hub/substrate-parachain-template/pull/133

Its a change across substrate

wilwade · 2022-12-13T13:11:10Z

pallets/messages/src/weights.rs

 			// Standard Error: 139_000
 			.saturating_add(Weight::from_ref_time(4_711_000 as u64).saturating_mul(s as u64))
 			.saturating_add(T::DbWeight::get().reads(1 as u64))
+			.saturating_add(T::DbWeight::get().writes(2 as u64))


Where did these come from?

Also we should likely run benchmarks before merging right? Lots of weights could/should have changed

Older weights than Main , need to run benchmarks before merge to update these

wilwade · 2022-12-13T13:12:49Z

pallets/msa/src/weights.rs

 			// Standard Error: 6_000
 			.saturating_add(Weight::from_ref_time(1_193_000 as u64).saturating_mul(s as u64))
 			.saturating_add(T::DbWeight::get().reads(2 as u64))
+			.saturating_add(T::DbWeight::get().writes(5 as u64))


Another weights update I didn't expect.

I think these are just older weights, I need to run the benchmarks on this PR

wilwade · 2022-12-13T13:15:02Z

runtime/frequency/src/lib.rs

 	impl_name: create_runtime_str!("frequency"),
 	authoring_version: 1,
-	spec_version: 3,
+	spec_version: 4,


saraswatpuneet · 2022-12-13T13:52:23Z

integration-tests/package.json

    "license": "Apache-2.0",
    "dependencies": {
-        "@frequency-chain/api-augment": "v0.9.29",
+        "@frequency-chain/api-augment": "^v0.9.29",


This is mostly done as .9.30 wont be available until release, so pinning on last stable release

I need to make it so that for CI this builds and uses the "local" version so they stay in sync for ci. On my need a break list ;)

wilwade

Approved (benchmarks are running)

saraswatpuneet added 3 commits December 5, 2022 09:01

minor update

1979802

upgrade to .9.30

e9477ae

upgrade to 0.9.30

9c38776

demisx mentioned this pull request Dec 5, 2022

[Governance] Create and document chain upgrade process + requirements checklist #249

Closed

9 tasks

saraswatpuneet and others added 3 commits December 5, 2022 12:11

weight updates

8cf16f1

set runtime origin in mocks/tests

2629e86

install protobuf package

0cb2fb6

saraswatpuneet added 2 commits December 5, 2022 14:37

fix tests, weights and benchmarks for .9.30

9237063

Merge branch 'chore/upgrade_0.9.32-fix-ci' into chore/upgrade_0.9.32

f6b6e86

saraswatpuneet changed the title ~~Chore/upgrade 0.9.32~~ Chore/upgrade 0.9.30 Dec 5, 2022

Merge branch 'main' into chore/upgrade_0.9.32

bb39813

saraswatpuneet marked this pull request as ready for review December 5, 2022 20:54

saraswatpuneet requested review from demisx and wilwade as code owners December 5, 2022 20:54

shannonwells reviewed Dec 5, 2022

View reviewed changes

saraswatpuneet added 2 commits December 5, 2022 16:42

include benchmarking updates for .9.30

fab754f

Merge branch 'chore/upgrade_0.9.32' of ssh://github.com/LibertyDSNP/f…

a21e7e4

…requency into chore/upgrade_0.9.32

saraswatpuneet changed the title ~~Chore/upgrade 0.9.30~~ [CHORE] Update Frequency to v0.9.30 Dec 5, 2022

saraswatpuneet mentioned this pull request Dec 6, 2022

[CHORE] Upgrade version to v0.9.32 #751

Merged

3 tasks

aramikm approved these changes Dec 6, 2022

View reviewed changes

demisx reviewed Dec 6, 2022

View reviewed changes

saraswatpuneet added 6 commits December 5, 2022 22:30

pin for integration tests

4ca7556

update lock file

72d6d4f

update weights and finalize .9.30

32be1e7

Merge branch 'main' into chore/upgrade_0.9.32

400d71e

Merge branch 'main' into chore/upgrade_0.9.32

ec35fa6

Merge branch 'main' into chore/upgrade_0.9.32

f5fc748

saraswatpuneet commented Dec 7, 2022

View reviewed changes

.github/workflows/verify-pr-commit.yml Show resolved Hide resolved

saraswatpuneet and others added 6 commits December 7, 2022 07:17

try rebuild

818b64d

Merge branch 'main' into chore/upgrade_0.9.32

bc612aa

install protoc for docs steps

c53eb9b

Merge branch 'main' into chore/upgrade_0.9.32

41d6f2a

Merge branch 'main' into chore/upgrade_0.9.32

b6ac80d

add missing steps

edf297a

saraswatpuneet added blocked Blocked by another issue and removed blocked Blocked by another issue labels Dec 8, 2022

Merge branch 'main' into chore/upgrade_0.9.32

6014fba

wilwade added the change/major Major Changes in this PR label Dec 13, 2022

wilwade reviewed Dec 13, 2022

View reviewed changes

sync with main

08a1d48

saraswatpuneet commented Dec 13, 2022

View reviewed changes

wilwade approved these changes Dec 13, 2022

View reviewed changes

Updating Benchmark Files

ed504d7

saraswatpuneet merged commit da4426f into main Dec 13, 2022

saraswatpuneet deleted the chore/upgrade_0.9.32 branch December 13, 2022 15:46

Conversation

saraswatpuneet commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Major updates from 0.9.29 to 0.9.30:

Checklist

Uh oh!

demisx commented Dec 5, 2022

Uh oh!

shannonwells left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aramikm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saraswatpuneet Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

demisx left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wilwade left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilwade left a comment

Choose a reason for hiding this comment

Uh oh!

saraswatpuneet commented Dec 5, 2022 •

edited

Loading

codecov bot commented Dec 5, 2022 •

edited

Loading

saraswatpuneet Dec 6, 2022 •

edited

Loading

demisx left a comment •

edited

Loading