Remove unused JUNCTION and LOAD component categories
#467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:actor
shsms
force-pushed
the
remove-junctions
branch
2 times, most recently
from
315aa7d to
bcfb946
Compare
Contributor
Author
|
I have split this into a number of smaller commits, in case that's easier to review. |
llucax
previously approved these changes
Jul 3, 2023
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
I guess this doesn't need a release notes entry? Maybe the Empty -> None?
Contributor
Author
true, added a line, just in case. |
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
We used to filter out `LOAD` components in the MicrogridClient, because those were always just placeholders, and not actual active components that can stream data. Now that the LOAD components are going away, we don't have to filter by them anymore. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Also adjust component graph connections such that there are no broken connections from the removal of `JUNCTION` components. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
llucax
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These component categories are deprecated, and are no longer used in production, and have been removed from the microgrid API v0.15.1, which we will update to soon.
This PR also fixes a protobuf generated type getting leaked outside the MicrogridClient.