Limit pydantic to v1 #475
Merged
Limit pydantic to v1 #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears v2 has breaking changes which we need to adjust for later. Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
shsms
requested review from
matthias-wende-frequenz
and removed request for
a team
github-actions
bot
added
the
part:tooling
llucax
approved these changes
Jul 3, 2023
llucax
requested changes
Jul 3, 2023
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
Wait, no. What do you mean 0.16?
Contributor
|
Oh, you really mean a very old version of the SDK? It seems like many other things are breaking. I don't think we pinned deps in older versions, so it might be a huge challenge to get them working at all. |
Contributor
Author
we did. I think only the grpc typing is failing. I will try and fix it. |
llucax
approved these changes
Jul 3, 2023
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears v2 has breaking changes which we need to adjust for later.
This PR adds the fix to the v0.16.x branch, and also pins the version of the grpc-stubs package.