Fix tests #170
Fix tests #170
Conversation
credits: code basically taken from the initial post of frescobaldi#153
This comment was marked as outdated.
This comment was marked as outdated.
The parser requires either a unicode string without encoding declaration in the XML document or bytes input with encoding declaration.
|
Tests pass now. |
| </note> | ||
| </measure> | ||
| <measure number="2"> | ||
| <print new-system="yes" /> |
There was a problem hiding this comment.
✔️ correct MusicXML equivalent of lily \break
| <type>quarter</type> | ||
| </note> | ||
| </measure> | ||
| <measure number="3" /> |
There was a problem hiding this comment.
Seems to be correct - break.ly only has musical content for two measures.
| </direction-type> | ||
| </direction> | ||
| </measure> | ||
| <measure number="2"> |
There was a problem hiding this comment.
✔️ correct - dynamics.ly doesn't specify \time, so the default 4/4 is used
| <line>2</line> | ||
| </clef> | ||
| </attributes> | ||
| <direction placement="above"> |
There was a problem hiding this comment.
❌ the markup does belong here, it shouldn't be removed
tests/test_xml_files/markup.xml
Outdated
| <direction placement="above"> | ||
| <direction-type> | ||
| <words>poco più forte </words> | ||
| <words>intenso poco più forte </words> |
There was a problem hiding this comment.
❌ incorrect merge of two markups - only "poco più forte" belongs here, "intenso" should be in measure 2
| </identification> | ||
| <part-list> | ||
| <part-group number="1" type="start"> | ||
| <part-group type="start" number="1"> |
There was a problem hiding this comment.
✔️ mere attribute order change
| </identification> | ||
| <part-list> | ||
| <part-group number="1" type="start"> | ||
| <part-group type="start" number="1"> |
There was a problem hiding this comment.
✔️ mere attribute order change
| <type>eighth</type> | ||
| </note> | ||
| </measure> | ||
| <measure number="1"> |
There was a problem hiding this comment.
❌ This is definitely incorrect. The original content was correct (or at least renders in the desired way in MuseScore).
| <direction-type> | ||
| <rehearsal>A</rehearsal> | ||
| </direction-type> | ||
| </direction> |
There was a problem hiding this comment.
I can't tell for sure if the changes to this file are correct, but the result renders in MuseScore almost the same mark.ly renders in LilyPond. Just a trailing measure with a rest is added.
manual partial revert of 754fec1
|
At least for now I'm done here. Tests are updated. Two are failing - because of issues in the export implementation, not because of outdated test code and examples. |
2 participants
This is an attempt to fix #153
As there were major differences between the expected and actual XML output, I regenerated all the XML examples with current python-ly.