This repository was archived by the owner on Feb 15, 2024. It is now read-only.
Move @ember/test-helpers and qunit into devDependencies#1
Merged
Conversation
nptel48
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
@ember/test-helpersin dependencies is causing issues with embroider. I think it makes more sense to have it in devDependencies anyways. I've also moved qunit. Having qunit in dependencies is causing magnum to install two versions of qunit (2.14.0 and 2.19.1).I've tested the changes with magnum already (https://github.com/freshbooks/magnum-ui/pull/11252) and it appears that the pact tests continue to run fine.