-
-
Notifications
You must be signed in to change notification settings - Fork 27
feat(sentry): improve coroutine backtrace filtering #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sentry): improve coroutine backtrace filtering #1000
Conversation
- Add 'Hyperf\Coroutine\wait' and 'wait' to skip functions list - Add 'FriendsOfHyperf\Sentry\Transport\CoHttpTransport->loop' to break functions list This improves the accuracy of backtrace filtering for Sentry error reporting by including additional coroutine-related functions that should be skipped or treated as break points during stack trace analysis.
详细概述Walkthrough在 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
🔇 Additional comments (3)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.31)At least one path must be specified to analyse. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add 'Hyperf\Coroutine\wait' and 'wait' to skip functions list - Add 'FriendsOfHyperf\Sentry\Transport\CoHttpTransport->loop' to break functions list This improves the accuracy of backtrace filtering for Sentry error reporting by including additional coroutine-related functions that should be skipped or treated as break points during stack trace analysis. Co-authored-by: Deeka Wong <8337659+huangdijia@users.noreply.github.com>
Summary
Hyperf\Coroutine\waitandwaitto skip functions listFriendsOfHyperf\Sentry\Transport\CoHttpTransport->loopto break functions listDetails
This PR improves the accuracy of backtrace filtering for Sentry error reporting by including additional coroutine-related functions that should be handled during stack trace analysis:
Hyperf\Coroutine\waitandwaitto ensure these coroutine utility functions are properly skipped during backtrace processingFriendsOfHyperf\Sentry\Transport\CoHttpTransport->loopto treat this transport loop as a break point in the stack traceThese changes ensure cleaner and more meaningful stack traces are reported to Sentry by filtering out internal coroutine management functions.
Test plan
Summary by CodeRabbit