fix: correct pool property initialization in dispatch classes #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PendingAsyncQueueDispatchandPendingKafkaProducerMessageDispatchclassespublic string $pool = 'default'topublic ?string $pool = null__destruct()methods to use null coalescing operator (??) to default to'default'when pool is nullDispatchTestto expectnullfor the pool property default valueBackground
The previous implementation initialized the
poolproperty with a default value of'default', which prevented proper null checks and could cause issues with pool configuration. The new implementation uses a nullable type with null coalescing in the destructor, maintaining backward compatibility while providing clearer semantics.Changes
Code Changes
nullinstead of'default'Test Plan
testBackwardCompatibilityWithBasicDispatchnow passes'default'pool when none is specifiedBackward Compatibility
✅ This change is backward compatible. The behavior remains the same - when no pool is specified, the
'default'pool is used via the null coalescing operator in the destructor.Summary by CodeRabbit
发行说明