-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add type tests for AMQP and Kafka dispatch return types #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com>
|
@copilot run composer cs-fix |
huangdijia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot fix code style
Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com>
Fixed code style in commit d37d052. Removed empty parentheses from anonymous class declaration to match existing patterns in the file. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com>
…type assertions in tests
* Initial plan * Add AMQP and Kafka type tests for dispatch function Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com> * Fix code style - remove empty parentheses from anonymous class Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com> * Fix code style - break long lines for readability Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com> * fix: update return type annotation for dispatch function and improve type assertions in tests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: huangdijia <8337659+huangdijia@users.noreply.github.com>
Add type tests for AMQP and Kafka message dispatch
Plan
Summary
Successfully added complete type test coverage for the
FriendsOfHyperf\Support\dispatchfunction.Changes Made
Modified
types/Support/Support.phpto add two new type assertions:Hyperf\Amqp\Message\ProducerMessagereturnsPendingAmqpProducerMessageDispatchlonglang\phpkafka\Producer\ProduceMessagereturnsPendingKafkaProducerMessageDispatchCode Style
Coverage
The dispatch function now has complete type test coverage:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.