-
-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add server address tracing for Redis connections #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ee65ee
feat: add server address tracing for Redis connections
huangdijia 238fa35
feat: improve server address handling for Redis connections
huangdijia db8c96e
feat: 添加 Redis 服务器地址和端口追踪常量,并更新相关逻辑
huangdijia 528a46a
feat: 更新 Redis 连接追踪逻辑以直接获取服务器地址和端口
huangdijia ca6a665
feat: 更新 Redis 连接追踪逻辑,添加注释以区分 Redis 和 RedisCluster
huangdijia a6d7b99
fix: 修正 RedisConnectionAspect 中的变量命名以提高代码可读性
huangdijia 0b31cb9
feat: 启用 RedisConnectionAspect 以支持 Redis 连接追踪
huangdijia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * This file is part of friendsofhyperf/components. | ||
| * | ||
| * @link https://github.com/friendsofhyperf/components | ||
| * @document https://github.com/friendsofhyperf/components/blob/main/README.md | ||
| * @contact huangdijia@gmail.com | ||
| */ | ||
|
|
||
| namespace FriendsOfHyperf\Sentry\Tracing\Aspect; | ||
|
|
||
| use FriendsOfHyperf\Sentry\Constants; | ||
| use Hyperf\Context\Context; | ||
| use Hyperf\Di\Aop\AbstractAspect; | ||
| use Hyperf\Di\Aop\ProceedingJoinPoint; | ||
| use Redis; | ||
| use RedisCluster; | ||
|
|
||
| use function Hyperf\Tappable\tap; | ||
|
|
||
| class RedisConnectionAspect extends AbstractAspect | ||
| { | ||
| public array $classes = [ | ||
| 'Hyperf\Redis\RedisConnection::__call', | ||
| ]; | ||
|
|
||
| public function process(ProceedingJoinPoint $proceedingJoinPoint) | ||
| { | ||
| return tap($proceedingJoinPoint->process(), function ($result) use ($proceedingJoinPoint) { | ||
| $redisConnection = $proceedingJoinPoint->getInstance(); | ||
| $connection = (fn () => $this->connection ?? null)->call($redisConnection); | ||
|
|
||
| if ($connection instanceof Redis) { // Redis or RedisSentinel | ||
| Context::set(Constants::TRACE_REDIS_SERVER_ADDRESS, $connection->getHost()); | ||
| Context::set(Constants::TRACE_REDIS_SERVER_PORT, $connection->getPort()); | ||
| } | ||
huangdijia marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if ($connection instanceof RedisCluster) { // RedisCluster | ||
| // TODO: support RedisCluster | ||
| } | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.