fix: replace filter with contains method in ClassAliasAutoloader

[huangdijia]

Summary

• Replace filter()->isEmpty() with contains() method in ClassAliasAutoloader
• Improves performance and code clarity for alias checking logic
• Uses more appropriate collection method for existence checks

Test plan

• Verify class alias autoloading still works correctly
• Test that included and excluded aliases are properly handled
• Run existing test suite to ensure no regressions
• Check performance improvement in alias resolution

Summary by CodeRabbit

发布说明

• 重构
  • 优化了内部类别检查逻辑，提升代码性能和可维护性。

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

演示说明

在 ClassAliasAutoloader.php 中，将两处 filter(...)->isEmpty() 调用替换为 contains(...) 调用，用于在包含和排除别名列表中检测类别匹配。控制流从检查过滤集合是否为空改为直接基于谓词的检查。

变更

内聚组 / 文件	变更摘要
别名检查逻辑优化 src/tinker/src/ClassAliasAutoloader.php	使用 contains() 替换 filter()->isEmpty() 两处调用以检测别名匹配。isAliasable() 方法中的 includedAliases 和 excludedAliases 检查改为直接谓词驱动的方式。

预期代码审查工作量

🎯 2 (简单) | ⏱️ ~8 分钟

• 确认 contains() 方法的逻辑与原有 filter()->isEmpty() 行为完全等价
• 验证谓词 str_starts_with($class, $alias) 的传递和执行方式正确

诗作

🐰 滤过千般，归于一线，
谓词驱驱，检测变简。
直指其心，别名既现，
代码流畅，效率倍献。✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Pull request title accurately describes the main change: replacing filter(...)->isEmpty() with contains() method in ClassAliasAutoloader for better code clarity and performance.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/class-alias-autoloader-contains-method

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99240c1 and bdb0b7e.

📒 Files selected for processing (1)

• src/tinker/src/ClassAliasAutoloader.php (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/*/src/**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

All components use the namespace pattern: FriendsOfHyperf\{ComponentName}

Files:

• src/tinker/src/ClassAliasAutoloader.php

**/*.php

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.php: Follow PSR-12 coding standards for all PHP code
Use PHP-CS-Fixer for code formatting as configured in .php-cs-fixer.php
Use PHPStan for static analysis as configured in phpstan.neon.dist

Files:

• src/tinker/src/ClassAliasAutoloader.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)

• GitHub Check: Test on PHP 8.2 with Swoole 5.1.8
• GitHub Check: Test on PHP 8.1 with Swoole 5.1.8
• GitHub Check: Test on PHP 8.1 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.1 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.2 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.3 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.2 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.3 with Swoole 5.1.8
• GitHub Check: Test on PHP 8.3 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.1 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.2 with Swoole 5.1.8
• GitHub Check: Test on PHP 8.1 with Swoole 5.1.8
• GitHub Check: Test on PHP 8.2 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.2 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.1 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.3 with Swoole 6.0.2
• GitHub Check: Test on PHP 8.3 with Swoole 6.1.3
• GitHub Check: Test on PHP 8.3 with Swoole 5.1.8

🔇 Additional comments (1)

src/tinker/src/ClassAliasAutoloader.php (1)

121-131: 使用 contains 闭包替换 filter()->isEmpty() 的改动本身是等价且更直接的

• 对 includedAliases 与 excludedAliases 两处来说，! $collection->contains(fn ($alias) => str_starts_with($class, $alias)) 与原来的 filter(...)->isEmpty() 语义上一致，只是更清楚地表达了“是否存在前缀匹配项”，同时避免构造中间集合，属于轻量的性能与可读性优化，这一点是 👍 的。
• 由于这里依赖的是 hyperf/collection 提供的 Collection::contains(Closure) 行为（通常会通过 first() 做短路判断），建议结合当前依赖版本再确认一下 closure 形态的 contains 与之前 filter(...)->isEmpty() 的返回语义在所有边界场景（空集合、单元素、多元素）下完全一致。

另外顺便提一点（不要求在本 PR 里改，只是提醒确认语义是否符合预期）：

• 目前 isAliasable() 中：
  • 未命中任一 includedAliases 前缀就直接 return true；
  • 之后如果命中了 includedAliases 且不在 vendorPath 下，但未命中任一 excludedAliases 前缀则 return false。
• 这个控制流与注释里的 “Explicitly included namespaces/classes” / “Excluded namespaces/classes” 在直觉上有点相反，更像是 “只有命中 included 才进一步检查 vendor / excluded，且只有命中 excluded 时才允许 alias”。如果外部传入的确是类似 include / dont_alias 这样的配置，建议在后续单独 PR 或 issue 里再整体审视一下这两个条件分支的方向是否与配置 / 文档相符，以免长期存在行为与命名不一致的陷阱。

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.32)

At least one path must be specified to analyse.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}