Skip to content

Improve trigger config #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangdijia merged 5 commits into from
Dec 27, 2024
Merged

Improve trigger config #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32e4d65
Improve trigger config
huangdijia Dec 23, 2024
b86010b
refactor(trigger): simplify Config class and remove dependency on Hyp…
huangdijia Dec 23, 2024
b655196
feat(trigger): add has() method to Config class for key existence check
huangdijia Dec 23, 2024
2f51780
fix(trigger): update subscribers method docblock for correct namespace
huangdijia Dec 23, 2024
94c3638
Update Config.php
huangdijia Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/trigger/src/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,21 @@

namespace FriendsOfHyperf\Trigger;

class Config extends \Hyperf\Config\Config
use Hyperf\Collection\Arr;

class Config
{
public function __construct(private array $configs = [])
{
}

public function get(string $key, mixed $default = null): mixed
{
return Arr::get($this->configs, $key, $default);
}

public function has(string $key): bool
{
return Arr::has($this->configs, $key);
}
}
1 change: 0 additions & 1 deletion src/trigger/src/Consumer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use FriendsOfHyperf\Trigger\Monitor\HealthMonitor;
use FriendsOfHyperf\Trigger\Mutex\ServerMutexInterface;
use FriendsOfHyperf\Trigger\Snapshot\BinLogCurrentSnapshotInterface;
use Hyperf\Config\Config;
use Hyperf\Coordinator\Constants;
use Hyperf\Coordinator\CoordinatorManager;
use Hyperf\Coroutine\Coroutine;
Expand Down
Loading