fix(sentry): prevent crash on non-scalar redis parameters using RedisCommand

[alexsyvolap]

Summary by CodeRabbit

• 重构
  • 简化了 Redis 命令字符串的构建和复用逻辑，优化了相关描述信息的生成方式。

[coderabbitai]

Walkthrough

此次更改对 TracingRedisListener 的 process 方法进行了重构，优化了 Redis 命令字符串的生成与复用方式。原本在方法中两次创建 RedisCommand 对象并转为字符串，现在只生成一次并存储在 $redisStatement 变量中，多处复用。同时，span 描述的构建方式也由条件格式化改为直接使用完整的 Redis 命令字符串，简化了逻辑。

Changes

文件/路径	变更摘要
src/sentry/src/Tracing/Listener/TracingRedisListener.php	重构 Redis 命令字符串的生成和复用，简化 span 描述的构建逻辑。

Possibly related PRs

• Improved redis tracing #847：同样修改了 TracingRedisListener.php 文件，优化了 Redis 命令字符串的构建与复用，统一了 RedisCommand 类的字符串表示方式。

Poem

小兔敲键盘，代码巧翻新，
Redis 命令只生成一身，
复用变量少跑腿，
描述简化更清真。
轻盈步伐跃进步，
代码世界更轻松！
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 436a5fb and 1dd617f.

📒 Files selected for processing (1)

• src/sentry/src/Tracing/Listener/TracingRedisListener.php (2 hunks)

🔇 Additional comments (3)

src/sentry/src/Tracing/Listener/TracingRedisListener.php (3)

55-56: 优化了Redis命令字符串的生成方式

通过创建RedisCommand对象并转换为字符串后存储在$redisStatement变量中，避免了多次创建相同对象的性能开销。这种重构使代码更加高效，同时也解决了非标量Redis参数可能导致的崩溃问题。

---

64-64: 正确使用预先生成的Redis命令字符串

使用预先生成的$redisStatement作为db.statement的值，保持了数据一致性，同时避免了重复转换的开销。

---

74-74: 简化了span描述的构建方式

直接使用完整的Redis命令字符串$redisStatement作为span描述，替代了之前可能存在的条件格式化逻辑。这种改进不仅简化了代码，还确保了span描述与数据中的db.statement保持一致，提高了可追踪性。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alexsyvolap]

Case when it crashed in my project:

<?php
declare(strict_types=1);

namespace App\Service;

use Hyperf\Redis\Redis;

class SomeService
{
    public function __construct(private Redis $redis) {}

    public function execute()
    {
        $this->redis->sAddArray('some_key', ['key1' => 'value1', 'key2' => 'value2']);
    }
}

Array to string conversion in implode(' ', [$event->parameters[0] ?? '', $event->parameters[1] ?? '']) because $event->parameters[1] is array