-
-
Notifications
You must be signed in to change notification settings - Fork 27
chore: fix naming/spelling; rename DatabaseMessages→DatabaseMessage (BC alias) #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…BC alias) - Replace 'Not Support job type.' with 'Unsupported job type.' - Correct 'will removed' → 'will be removed' in deprecations - Improve ReCaptcha not published message - Deprecate EntryType::SCHEDULED_TASK as alias of SCHEDULE - Rename DatabaseMessages to DatabaseMessage; update tests; add class_alias for BC - Tweak cache ConfigProvider comments
|
Caution Review failedThe pull request is closed. Walkthrough本次变更主要修正多处注释中的弃用文案语法;新增通知模块的 DatabaseMessage 值对象,并将 DatabaseMessages 标记为弃用且继承自新类;更新部分错误/异常消息文本;在 Telescope 增加一个兼容性别名常量;相应更新了测试桩代码。 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor App as Application
participant Notifiable
participant Notification
participant Channel as DatabaseChannel
participant DB as Database
App->>Notification: 触发通知
Notification->>Notifiable: 针对 Notifiable 构建负载
Notification->>Channel: toDatabase() 返回 DatabaseMessage(data)
Channel->>DB: 插入 data 到通知表
DB-->>Channel: 写入结果
Channel-->>App: 完成
note over Channel,DB: 新增 DatabaseMessage;DatabaseMessages 现为继承且弃用
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.17)Note: Using configuration file /phpstan.neon.dist. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (13)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
…BC alias) (#892) * chore: fix naming/spelling; rename DatabaseMessages→DatabaseMessage (BC alias) - Replace 'Not Support job type.' with 'Unsupported job type.' - Correct 'will removed' → 'will be removed' in deprecations - Improve ReCaptcha not published message - Deprecate EntryType::SCHEDULED_TASK as alias of SCHEDULE - Rename DatabaseMessages to DatabaseMessage; update tests; add class_alias for BC - Tweak cache ConfigProvider comments * fix: update deprecation notice for DatabaseMessages class * refactor: remove DatabaseMessages class and update deprecation notice for DatabaseMessage --------- Co-Authored-By: Deeka Wong <8337659+huangdijia@users.noreply.github.com>
This PR fixes wording/naming issues and clarifies deprecations.
Changes:
Notes:
Summary by CodeRabbit
新功能
重构
文档
样式