-
-
Notifications
You must be signed in to change notification settings - Fork 27
fix(sentry): correct origin semantic convention for Monolog handler #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes sentry.origin from 'auto.logger.monolog' to 'auto.log.monolog' to comply with Sentry's semantic conventions for log instrumentation. According to Sentry's semantic conventions, the origin value for logs should use 'log' instead of 'logger' to properly identify the instrumentation type.
概览修改了 Sentry Monolog 集成中的来源元数据。将传递给日志聚合器的上下文中的 'sentry.origin' 值从 'auto.logger.monolog' 变更为 'auto.log.monolog'。控制流和错误处理逻辑保持不变。 变更
估计代码审查工作量🎯 1 (微小) | ⏱️ ~3 分钟 相关的 Pull Request
诗
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)src/*/src/**/*.php📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
**/*.php📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
🔇 Additional comments (1)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.1.31)At least one path must be specified to analyse. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the sentry.origin semantic convention value in the Monolog LogsHandler to align with Sentry's official telemetry standards. The change updates the origin identifier from auto.logger.monolog to auto.log.monolog, ensuring proper categorization of log instrumentation in Sentry's observability platform.
Key Changes:
- Updated the
sentry.originattribute value to use the correct semantic convention format (auto.log.*instead ofauto.logger.*)
…965) Changes sentry.origin from 'auto.logger.monolog' to 'auto.log.monolog' to comply with Sentry's semantic conventions for log instrumentation. According to Sentry's semantic conventions, the origin value for logs should use 'log' instead of 'logger' to properly identify the instrumentation type. Co-authored-by: Deeka Wong <8337659+huangdijia@users.noreply.github.com>
Summary
This PR corrects the
sentry.originattribute value in the Monolog LogsHandler to comply with Sentry's semantic conventions.Changes
sentry.originfromauto.logger.monologtoauto.log.monologinsrc/sentry/src/Monolog/LogsHandler.php:63Rationale
According to Sentry's semantic conventions, the origin value for log instrumentation should use
auto.log.*instead ofauto.logger.*to properly identify the instrumentation type. This ensures consistency with Sentry's telemetry standards and improves observability data quality.Test Plan
sentry.originattribute appears asauto.log.monologin Sentry UIfix:#965
Summary by CodeRabbit
发布说明