Skip to content

Conversation

@seanspeaks
Copy link
Contributor

@seanspeaks seanspeaks commented Mar 24, 2025

TL;DR

Added token handling for Asana API and optimized Frontify's nested folder query structure.

What changed?

  • Asana API: Implemented a setTokens method to properly handle access tokens, expiration times, and token updates.
  • Frontify API: Reduced the maximum folder nesting depth from 10 to 5 to prevent hitting GraphQL query depth limits, and simplified the pagination properties in nested folder queries.

How to test?

  1. Asana: Test OAuth flow to verify tokens are properly set and expiration times are calculated correctly.
  2. Frontify: Test folder queries with deep nesting to ensure they work without hitting GraphQL depth limits.

Why make this change?

  • Asana: The implementation was missing proper token handling, which is necessary for maintaining authentication state.
  • Frontify: The previous implementation risked hitting GraphQL query depth limits (max 20) when querying deeply nested folders. Reducing the max depth to 5 ensures we stay within limits while accounting for other fields in the query structure.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @friggframework/api-module-asana@1.1.6-canary.32.a7101da.0
npm install @friggframework/api-module-frontify@1.3.1-canary.32.a7101da.0
# or 
yarn add @friggframework/api-module-asana@1.1.6-canary.32.a7101da.0
yarn add @friggframework/api-module-frontify@1.3.1-canary.32.a7101da.0

Version

Published prerelease version: @friggframework/api-module-asana@2.0.0-next.4
@friggframework/api-module-frontify@2.0.0-next.7

Changelog

🐛 Bug Fix

  • @friggframework/api-module-asana, @friggframework/api-module-frontify
    • Did things, third time trying to type this commit message #32 (@seanspeaks)
  • @friggframework/api-module-microsoft-teams, @friggframework/api-module-slack, @friggframework/api-module-42matters, @friggframework/api-module-asana, @friggframework/api-module-attio, @friggframework/api-module-connectwise, @friggframework/api-module-contentful, @friggframework/api-module-contentstack, @friggframework/api-module-crossbeam, @friggframework/api-module-deel, @friggframework/api-module-frontify, @friggframework/api-module-google-calendar, @friggframework/api-module-google-drive, @friggframework/api-module-helpscout, @friggframework/api-module-hubspot, @friggframework/api-module-ironclad, @friggframework/api-module-linear, @friggframework/api-module-salesforce, @friggframework/api-module-stripe, @friggframework/api-module-unbabel-projects, @friggframework/api-module-unbabel, @friggframework/api-module-zoho-crm, @friggframework/api-module-zoom
    • node:form-data doesn't exist. Thanks Cursor/AI and my like of node knowledge. #31 (@seanspeaks)

Authors: 1

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@seanspeaks seanspeaks marked this pull request as ready for review March 24, 2025 00:24
@seanspeaks seanspeaks merged commit 7ced827 into next Mar 24, 2025
4 checks passed
Copy link
Contributor Author

Merge activity

  • Mar 23, 8:24 PM EDT: A user merged this pull request with Graphite.

@seanspeaks
Copy link
Contributor Author

@seanspeaks seanspeaks added the prerelease This change is available in a prerelease. label Mar 24, 2025
@seanspeaks seanspeaks deleted the asana-refresh-token-and-frontify-nested-max branch August 26, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prerelease This change is available in a prerelease. release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant