Merged
Conversation
- Updated `getMetadataFields` method to retrieve custom metadata properties. - Introduced `setAssetCustomMetadata` method for setting or updating custom metadata values on assets. - Improved type mapping for custom metadata properties.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+874
to
+879
| if (Array.isArray(e.value)) { | ||
| const values = e.value | ||
| .map((v) => normalizeValue(v)) | ||
| .filter((v) => v !== null) | ||
| .join(', '); | ||
| return `{ propertyId: "${e.propertyId}", values: [ ${values} ] }`; |
There was a problem hiding this comment.
The array handling in this code has a potential issue with GraphQL syntax. When joining normalized values with commas, string values aren't properly quoted in the resulting GraphQL query. For example, if e.value contains ["apple", "orange"], the current implementation would produce something like:
{ propertyId: "123", values: [ "apple", "orange" ] }But GraphQL requires each string value to be individually quoted:
{ propertyId: "123", values: [ "apple", "orange" ] }Consider modifying the array handling to ensure proper GraphQL syntax for all value types, particularly for arrays of strings.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Contributor
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests added new methods for retrieving and setting custom metadata fields from Frontify in the Frontify api-module.
Version
Published prerelease version:
@friggframework/api-module-frontify@2.0.0-next.9Changelog
🚀 Enhancement
@friggframework/api-module-frontify@friggframework/api-module-microsoft-teams,@friggframework/api-module-slack,@friggframework/api-module-42matters,@friggframework/api-module-asana,@friggframework/api-module-attio,@friggframework/api-module-connectwise,@friggframework/api-module-contentful,@friggframework/api-module-contentstack,@friggframework/api-module-crossbeam,@friggframework/api-module-deel,@friggframework/api-module-frontify,@friggframework/api-module-google-calendar,@friggframework/api-module-google-drive,@friggframework/api-module-helpscout,@friggframework/api-module-hubspot,@friggframework/api-module-ironclad,@friggframework/api-module-linear,@friggframework/api-module-salesforce,@friggframework/api-module-stripe,@friggframework/api-module-unbabel-projects,@friggframework/api-module-unbabel,@friggframework/api-module-zoho-crm,@friggframework/api-module-zoomAuthors: 2