fix: correct API name and enhance authorization requirements for scale-test module #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and improve logging in handleListContacts
seanspeaks
approved these changes
Oct 15, 2025
| return num - 1; | ||
| function findContactIndexByUUID(accountId: string, targetUUID: string): number | undefined { | ||
| // For UUID-based IDs, we need to search through indices to find a match | ||
| // This is acceptable for scale test purposes with 10k contacts |
Contributor
There was a problem hiding this comment.
This will be poor for 100k, 1 million etc yeah?
| let offset = cursorData?.offset ?? 0; | ||
| const since = parseUpdatedSince(params.updatedSince); | ||
| const contactIndexFilter = parseContactIndex(params.contactId); | ||
| const contactIndexFilter = params.contactId ? findContactIndexByUUID(params.accountId, params.contactId) : undefined; |
Contributor
There was a problem hiding this comment.
This will be funky/slow at some scale, but we can handle at a later date
| const limit = computeLimit(cursorData?.limit ?? params.limit, config); | ||
| let offset = cursorData?.offset ?? 0; | ||
| const since = parseUpdatedSince(params.updatedSince); | ||
| const mutations = await state.getLatestMutations(params.accountId, "contact"); |
Contributor
There was a problem hiding this comment.
We'll want to eventually optimize this, but unnecessary for the timebeing
Contributor
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Published prerelease version:
@friggframework/api-module-frigg-scale-test@0.2.0-next.3Changelog
🚀 Enhancement
@friggframework/api-module-frigg-scale-test@friggframework/api-module-microsoft-teams,@friggframework/api-module-slack,@friggframework/api-module-42matters,@friggframework/api-module-asana,@friggframework/api-module-attio,@friggframework/api-module-connectwise,@friggframework/api-module-contentful,@friggframework/api-module-contentstack,@friggframework/api-module-crossbeam,@friggframework/api-module-deel,@friggframework/api-module-frigg-scale-test,@friggframework/api-module-frontify,@friggframework/api-module-google-calendar,@friggframework/api-module-google-drive,@friggframework/api-module-helpscout,@friggframework/api-module-hubspot,@friggframework/api-module-ironclad,@friggframework/api-module-linear,@friggframework/api-module-salesforce,@friggframework/api-module-stripe,@friggframework/api-module-unbabel-projects,@friggframework/api-module-unbabel,@friggframework/api-module-zoho-crm,@friggframework/api-module-zoomAuthors: 1