Test1#1
Open
frontendpm wants to merge 2 commits intomainfrom
Open
Conversation
bartgarbiak
suggested changes
May 4, 2021
| 5. bonus: use Class | ||
| */ | ||
| function dialogBox($component) { | ||
| const questionContainer = $component.find('.question'); |
| function dialogBox($component) { | ||
| const questionContainer = $component.find('.question'); | ||
| const questionContainerHtml = questionContainer.html(); | ||
| const socialItem = $('.social-link'); |
There was a problem hiding this comment.
Suggested change
| const socialItem = $('.social-link'); | |
| const socialItems = $('.social-link'); |
| const buttonOk = $component.find('.button--ok'); | ||
| const buttonCancel = $component.find('.button--cancel'); | ||
| const dialogContainer = $('.dialog'); | ||
| let socialLink = socialItem.attr('data-url'); |
There was a problem hiding this comment.
There's no point putting this in this scope. This will be overwritten after each click, so could be a const inside event-handling function.
| closeDialog(); | ||
| } | ||
|
|
||
| init(); |
There was a problem hiding this comment.
What's the point of separate init function?
|
|
||
| init(); | ||
|
|
||
| function attachDialogBox() { |
| &--youtube { | ||
| background: url(https://www.magneticpoint.com/themes/custom/mp/assets/images/ic-youtube.svg) | ||
| center no-repeat; | ||
| filter: invert(21%) sepia(97%) saturate(6285%) hue-rotate(359deg) |
| center no-repeat; | ||
| filter: invert(21%) sepia(97%) saturate(6285%) hue-rotate(359deg) | ||
| brightness(100%) contrast(123%); | ||
| box-shadow: 2px 2px 2px rgb(165, 165, 165); |
| background-color: rgba($color-black, 0.5); | ||
| } | ||
|
|
||
| &--ok { |
There was a problem hiding this comment.
Nesting without indentation. I'm calling Amnesty International.
|
|
||
| &.is-hidden { | ||
| // display: none; | ||
| visibility: hidden; |
There was a problem hiding this comment.
Hmm, what's the difference? It will add .1s delay, thanks to transition, but what for?
| color: #000; | ||
| position: fixed; | ||
| @include mobile { | ||
| display: flex; |
vxda
reviewed
May 4, 2021
| const socialItem = $('.social-link'); | ||
| const buttonOk = $component.find('.button--ok'); | ||
| const buttonCancel = $component.find('.button--cancel'); | ||
| const dialogContainer = $('.dialog'); |
There was a problem hiding this comment.
redundant -
vxda
reviewed
May 4, 2021
|
|
||
| @mixin transition($property) { | ||
| transition-duration: .3s; | ||
| transition-delay: .1s; |
There was a problem hiding this comment.
inconsistent - once you are using .1 other time you are adding leading zero (0.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.