Test2#2
Open
frontendpm wants to merge 2 commits intomainfrom
Open
Conversation
vxda
suggested changes
May 14, 2021
| str = name; | ||
| } | ||
|
|
||
| $('.social-link').on('click', function() { |
| replaceNetworkName(socialNetworkName); | ||
| }); | ||
|
|
||
| $('.button--ok').on('click', function() { |
|
|
||
| $('.button--ok').on('click', function() { | ||
| //seems that redirection doesn't work on jsfiddle, but the function works correctly | ||
| window.location.href = 'http://' + socialNetworkName; |
There was a problem hiding this comment.
this is redirecting in same window and does not work in fiddle
| function replaceNetworkName(name) { | ||
| const regex = new RegExp(`${str}`, 'g') | ||
| const newhtml = $('.question').html().replace(regex, name); | ||
| $('.question').html(newhtml); |
|
|
||
| &:hover.button--cancel { | ||
| background-color: $cancel-button-color; | ||
| @include hover-transition(background-color); |
| &:hover { | ||
| @include hover-transition(transform); | ||
| box-shadow: 0 20px 30px rgba(0, 0, 0, 0.2); | ||
| transform: translateY(-0.5rem); |
| } | ||
|
|
||
| a { | ||
| @include button; |
| > div { | ||
| >div { | ||
| padding-bottom: 20px; | ||
| border-bottom: 1px solid #000; |
| color: #000; | ||
|
|
||
| @include not-mobile { | ||
| font-size: $font-size-mobile + $font-size-mobile *0.2; |
| } | ||
|
|
||
| @mixin hover-transition($transition-name) { | ||
| transition: $transition-name 300ms ease-out 0.1s; |
frontendpm
commented
May 14, 2021
| }); | ||
|
|
||
| $('.button--ok').on('click', function() { | ||
| //seems that redirection doesn't work on jsfiddle, but the function works correctly |
Owner
Author
There was a problem hiding this comment.
There is an error message
Mixed Content: The page at 'https://jsfiddle.net/marwinn/1v3x58jo/6/' was loaded over HTTPS, but requested an insecure frame 'http://facebook.com/'. This request has been blocked; the content must be served over HTTPS.
You should try window.open instead for example
| function replaceNetworkName(name) { | ||
| const regex = new RegExp(`${str}`, 'g') | ||
| const newhtml = $('.question').html().replace(regex, name); | ||
| $('.question').html(newhtml); |
Owner
Author
There was a problem hiding this comment.
always looking for new '.question' instead of cached it
| let socialNetworkName = ''; | ||
|
|
||
| function toggleDialog() { | ||
| $('.dialog').toggleClass('is-hidden'); |
Owner
Author
There was a problem hiding this comment.
dialog should be cached
| } | ||
| } | ||
|
|
||
| @mixin hover-transition($transition-name) { |
| } | ||
|
|
||
| .social-links { | ||
| li { |
| &:hover { | ||
| @include hover-transition(transform); | ||
| box-shadow: 0 20px 30px rgba(0, 0, 0, 0.2); | ||
| transform: translateY(-0.5rem); |
| .container { | ||
| @include mobile { | ||
| display: flex; | ||
| flex-wrap: nowrap; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.