Skip to content

fix: ignore invalid version strinig from winreg #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frostming merged 3 commits into from
Apr 18, 2024
Merged

fix: ignore invalid version strinig from winreg #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb0269
fix: ignore invalid version strinig from winreg
frostming Apr 18, 2024
b996e99
fix: only convert if not none
frostming Apr 18, 2024
aafa77f
fix name
frostming Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/findpython/providers/winreg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,15 @@ def find_pythons(self) -> t.Iterable[PythonVersion]:
continue
if path.exists():
py_version = getattr(version.info, "version", None)
parse_version: Version | None = None
if py_version:
try:
parse_version = Version(py_version)
except ValueError:
pass
py_ver = self.version_maker(
path,
Version(py_version) if py_version else None,
parse_version,
getattr(version.info, "sys_architecture", SYS_ARCHITECTURE),
path,
)
Expand Down