Added support for editing event priority groups.#218
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for editing event priority groups by modifying the event update logic, exposing a new API endpoint to retrieve priority roles, and updating the event schema with a priorities field.
- Updated event update logic to handle priority groups separately.
- Introduced a new endpoint to retrieve event priority roles.
- Extended the event schema to include a priorities field.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/event_service.py | Added conditional logic to delete and recreate priority groups |
| routes/event_router.py | Added new GET endpoint to return event priority roles |
| api_schemas/event_schemas.py | Updated EventUpdate schema with a new priorities field |
6 tasks
Contributor
Author
|
Potential hold to await #220 ? |
maffe03
approved these changes
Jul 5, 2025
Member
maffe03
left a comment
maffe03
left a comment
There was a problem hiding this comment.
MEMBER_ROLES is constant right?
In that case it LGTM
Contributor
Author
|
As the code is currently written MEMBER_ROLES is a constant. Not sure if we want the ability to add more priority groups via API in the future |
Member
|
Maybe, but not a priority for the foreseeable future. Merging this now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with fsek/WWW-Web#67 and just works.