Skip to content

RFC 1130 - Additions to collection functions in Array.Parallel #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cartermp merged 8 commits into from
Jul 5, 2023
Merged

RFC 1130 - Additions to collection functions in Array.Parallel #720

cartermp merged 8 commits into from
Jul 5, 2023

Conversation

@T-Gro
Copy link
Contributor

@T-Gro T-Gro commented Nov 4, 2022

Click “Files changed” → “⋯” → “View file” for the rendered RFC.

T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 4, 2022
View reviewed changes
T-Gro
T-Gro commented Nov 7, 2022
View reviewed changes
@kerams
Copy link
Contributor

kerams commented Nov 7, 2022 •
edited
Loading

This number is taken in another PR. I've just taken 1131, so that you can bump to 1130 here.

T-Gro
T-Gro commented Nov 7, 2022
View reviewed changes
@T-Gro T-Gro changed the title RFC 1129 - Additions to collection functions in Array.Parallel RFC 1130 - Additions to collection functions in Array.Parallel Nov 7, 2022
@T-Gro
Rename 1129-array-parallel-collection-functions-more-regular.md to 11…
4adfb6b 
…30-array-parallel-collection-functions-more-regular.md
cartermp
cartermp reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is fine, but it would be nice to have the signature for each written out in this RFC

@T-Gro
Copy link
Contributor Author

T-Gro commented Nov 10, 2022

Overall I think this is fine, but it would be nice to have the signature for each written out in this RFC

Done

@T-Gro
Copy link
Contributor Author

T-Gro commented Nov 10, 2022

Still remains to voted/indicated which functions are of the biggest desire.
(besides the ones having "ADD" in the rightmost column already).

@voronoipotato
Copy link
Contributor

voronoipotato commented Jan 30, 2023

Put in my 2c. I like the ones you added, I added a few optional ones but I don't want to block this. If adding them stretches out the date significantly I would prefer we pull this through as is. We can always add more later.

@T-Gro T-Gro requested a review from cartermp February 1, 2023 10:59
@baronfel
Copy link
Contributor

baronfel commented Jul 4, 2023

@T-Gro should this be merged now that all of the PRs are merged?

@cartermp
Copy link
Member

cartermp commented Jul 5, 2023

yup

@cartermp cartermp merged commit 330c97e into fsharp:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cartermp cartermp cartermp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@T-Gro @kerams @voronoipotato @baronfel @cartermp