Deurdu local #11

MuhammadTaha01 · 2024-12-21T16:59:38Z

Auto-Generated files were removed and all the commands to generate them were being written down (Readme.md) as per their specific files.

fsheikh · 2024-12-22T12:56:39Z

This branch still contains commits which are already present in my deurdu branch. See below

To move this forward, I would try to pick all the changes from be6a6dd into a new branch and open a PR, we can probably merge that branch then. But first please address rest of the review comments.

fsheikh

Not in merge-able form. Also please see questions/comments

fsheikh · 2024-12-22T11:44:12Z

server/Controllers/authController.js

+//     credentials: true // Allow cookies to be sent with requests
+// }));
+
+// app.use(cookieParser());
+
+// const db = mysql.createConnection({
+//     host: 'localhost',
+//     user: 'root',
+//     database: 'deurdu',
+//     password: ''
+// })


how is authentication happening if you commented out this part?

At first I was moving the project with JWT Tokens for auth, but after discussing with you, I moved to the auth0 user management system, through which we can handle the users and their authentication.
Therefore, there is not use of this authController.js file, that's why I had commented it.

see below comment

fsheikh · 2024-12-22T11:45:13Z

server/Controllers/authController.js

+
+
+
+export default router;


why do you return a router object if this it is no longer defined in this file.

You are right, I missed out to comment it out.

since this is currently not needed, please delete this file

Ok, the file is deleted.

fsheikh · 2024-12-22T11:46:04Z

server/Controllers/blogControllers.js

+const router = express.Router();
+
+// SQLite3 database connection
+const db = new sqlite3.Database('deurdu.db', (err) => {


can we define string constants like name of database and the filepaths in a separate file and then use here?

Yes, it is possible.
Let me share you a sample code, for the clear picture.

// config.js const path = require('path'); module.exports = { DATABASE_NAME: 'deurdu.db', UPLOADS_PATH: path.join(__dirname, 'uploads'), LOGS_PATH: path.join(__dirname, 'logs') };

And then:

const express = require('express'); const sqlite3 = require('sqlite3'); const { DATABASE_NAME } = require('./config'); const router = express.Router(); // SQLite3 database connection const db = new sqlite3.Database(DATABASE_NAME, (err) => { if (err) { console.error('Error connecting to database:', err.message); } else { console.log('Connected to the database.'); } }); module.exports = router;

will be incorporated in reviewed work

Sure, Got it.
I have made a Config.js file in server, where I have initialized the DB_NAME as the string constant.
Also I will add the comments in it for the assistance of you.

@MuhammadTaha01 where is this new configuration file uploaded, did you pull the branch taha_deurdu_local from #12 before introducing this file? I don´t see any changes added to that pull-request, last change being 5ba0ec6
May be you forgot to push your changes to the correct branch?

fsheikh · 2024-12-22T11:47:38Z

server/Controllers/blogControllers.js

+// Configure multer for file uploads
+const storage = multer.diskStorage({
+  destination: (req, file, cb) => {
+    cb(null, './pictures'); // Folder to save uploaded images


so the images will be saved in the directory <project-home>/server/Controllers/pictures ? or <project-home>/pictures. Also as mentioned above this path should be defined as a separate constant.

Paths and some other stuff could be defined in the separate file as the constant.
But, right now project isn't taking pictures in the database, as I told you earlier.
Currently, it is only taking the information of blogs like title, author name, content.
The image space isn't functional.

important is to to define a constant file path relative to server directory where all multimedia data received from Multer is saved. Backend then stores data in the database which maps these pictures to a particular blog

Ok, got it.
I have defined the Image Path as the string constant into the Config.js file.
The uploaded images will go to the derudu/server/Controllers/pictures.
And later on, will work on the functionality to upload the images too.

fsheikh · 2024-12-22T11:48:39Z

server/Controllers/blogControllers.js

+  },
+});
+
+const upload = multer({ storage });


where is this upload object after this definition?

As I stated in my above response, that uploading image functionality isn't working right now.

please add a TBD (To-Be-Done) comment above this line to indicate this still needs some more work

I have added a TBD comment on it, as it needs further implementation

fsheikh · 2024-12-22T12:45:06Z

client/src/Components/Navbar.jsx

+              {/* <Link to={`${getLanguagePath()}/login`}>
+                <button className='px-2 py-0.5 m-1 rounded-lg text-white'>{login}</button>
+              </Link>
+              <Link to={`${getLanguagePath()}/register`}>
+                <button className='px-2 py-0.5 m-1 rounded-lg text-white'>{register}</button>
+              </Link> */}


I see commented out code in many places, not sure if this is debugging leftover or not needed any longer

No, the commented code is for no needed longer.
But, in-case in in future, we think of migrating our webapp from auth0 to JWT Tokens.
It would be beneficial.

fsheikh · 2024-12-22T12:46:04Z

client/src/Components/Navbar.jsx

+        <div className={`flex bg-gray-700 ${i18.language === 'ur' ? 'gap-[775px]' : 'gap-[880px]'}
+                                            ${i18.language === 'de' ? 'gap-[700px]' : 'gap-[880px]'}`}>


same comment as above how can the developer know how many pixels are needed here, comparing 775px to 700px

The developer could evaluate that thing as per device, like for large screens (laptops etc...) it is good but for other screens it could be customize.

fsheikh · 2024-12-22T12:47:51Z

client/src/Pages/Login.jsx

+        gmail: '',
+        password: ''


login is only possible with gmail add or any other email address also possible?

For now it is not in use the Login.jsx and Signup.jsx page isn't in use.
As we are using auth0 as user management system.

fsheikh · 2024-12-22T12:51:28Z

client/src/Pages/Login.jsx

+            axios.post('http://localhost:3030/auth/login', values)
+            .then(res => 
+                {


is this the first time login path?

It is not in use as we are using auth0 as the user management system.

fsheikh · 2024-12-22T12:52:22Z

client/src/Pages/Login.jsx

+                    {
+                        alert('Error while registering the user.');
+                    }


This looks like the case when user was not authenticated so the error log is misleading. Also where is the handling for registering a first time user?

This error is for that if the user email and password, isn't find in database so this error will be pop-out.
But, for now it is not important as we are using auth0 as user management system.

fsheikh · 2024-12-23T08:40:48Z

server/README.md

+To regenerate the `package.json` file with default values, run the following command in the **server** directory:
+
+```bash
+npm init -y


this is not enough as it just generates an empty package.json file with the following contents

npm init -y Wrote to /home/q550356/sample_code/server/package.json: { "name": "server", "version": "1.0.0", "description": "If you've accidentally deleted the `package.json` or `package-lock.json` files in the **server** directory, you can follow these steps to regenerate them.", "main": "index.js", "scripts": { "test": "echo \"Error: no test specified\" && exit 1" }, "keywords": [], "author": "", "license": "ISC" }

I tried using the previous package file from https://github.com/fsheikh/sample_code/blob/deurdu/deurdu/server/package.json but then had to npm install express and npm install sqlite3

Oh ok, by the way I did that thing: npm init -y and it generated me that package.json file.
I don't know why, but we will discuss it on call.

as discussed, nothing to do here, #12 already has put back this configuration file. Just please use that branch as the base, meaning before making more changes, pull that branch locally taha_deurdu_local

fsheikh · 2024-12-23T08:43:50Z

deurdu/README.md

-This directory contains all data and source code for deurdu blogging
-website.
-


why you deleted the top level deurdu directory?

I didn't. I was also thinking that when I was just pushing my code to deurdu_branch_local, why the deurdu folder auto get's deleted.

fsheikh · 2024-12-23T09:00:33Z

client/README.md

+### 3️⃣ **Generate Missing Configuration Files**
+
+As some configuration files were deleted, you'll need to regenerate or create them manually. Here are the necessary steps for each file:
+## **For TailwindCSS:**
+Regenerate the ```tailwind.config.js``` file:
+```bash
+npx tailwindcss init
+```
+This will generate the ```tailwind.config.js``` file.
+
+## **For Vite:**


looks like each configuration needs a separate step, in this case it would be better to put these configuration in back in code.

You are right, it would.
But we can discuss it in deep on call.

fsheikh · 2024-12-23T09:01:31Z

client/README.md

+Once everything is set up, you can run the development server with one of the following commands:
+- Using npm:
+```bash
+npm run dev


after running the client, I land into by default urdu section which I think is wrong, also the URL contains undefined, not sure what that means

undefined means that app was unable to extract the selected lang from params and thus undefined comes there.
By the way the lang is set to be eng by default.

Agreed it is a bug and needs further investigation.

fsheikh

please address the review comments as discussed on the phone

fsheikh · 2024-12-25T14:08:40Z

client/README.md

+Once everything is set up, you can run the development server with one of the following commands:
+- Using npm:
+```bash
+npm run dev


Agreed it is a bug and needs further investigation.

fsheikh · 2024-12-25T14:13:05Z

server/index.js

+// Make the database connection available to routes
+app.use((req, res, next) => {
+  req.db = db; // Attach the database connection to the request object
+  next();


Please put documentation link in code itself: https://expressjs.com/en/guide/writing-middleware.html

fsheikh · 2024-12-25T14:21:07Z

server/index.js

+
+// Make the database connection available to routes
+app.use((req, res, next) => {
+  req.db = db; // Attach the database connection to the request object


so we need only one global initialization of sqlite3 database, so the one in https://github.com/fsheikh/sample_code/pull/11/files#diff-9ac2ac1d104a8ac8f861c556d1082ec1051171365a02a5e5355d49265b437177R8 should be removed.

fsheikh · 2024-12-25T14:25:18Z

server/index.js

+import express from 'express';
+import cors from 'cors';
+import sqlite3 from 'sqlite3'; // Import sqlite3
+import blogControllerRoutes from './Controllers/blogControllers.js';


as discussed offline blogControllerRoutes should be renamed to blogRoutes or something similar/simpler. And a comment mentioning that objects are being instantiated here at the top of the file.

fsheikh · 2024-12-25T14:35:47Z

server/README.md

+To regenerate the `package.json` file with default values, run the following command in the **server** directory:
+
+```bash
+npm init -y


as discussed, nothing to do here, #12 already has put back this configuration file. Just please use that branch as the base, meaning before making more changes, pull that branch locally taha_deurdu_local

fsheikh · 2024-12-25T15:16:51Z

client/src/Components/Cards.jsx

+
+const Cards = ({img,title,description}) => {
+    return (
+        <div className='flex flex-col w-[250px] m-6 border-2 border-black text-center p-2 rounded-lg'>


please add Tailwind documentation link defining styling attributes.

fsheikh · 2024-12-25T15:19:36Z

client/src/Components/Footer.jsx

+    const {ul1,ul2,ul3,ul4} = t('ulTranslation')
+
+    return(
+        <div className="bg-green-200 py-5 flex space-x-[1050px]">


No need to rerun the full client again, code changes are applied live. Further action pending on testing

fsheikh · 2024-12-25T15:23:35Z

client/src/Components/Footer.jsx

+                <li className="hover:underline transition cursor-pointer">{ul2}</li>
+                <li className="hover:underline transition cursor-pointer">{ul3}</li>
+                <li className="hover:underline transition cursor-pointer">{ul4}</li>


uli2 e.g. is a link still on homepage like AboutUs. Please populate the links with each ul value. Content can be empty but at least links should be established

fsheikh · 2024-12-25T15:31:20Z

client/src/Components/ImagesSlidebar.jsx

+  return (
+    <div className="slide-container">
+      <Fade>
+        {fadeImages.map((fadeImage, index) => (


please when using built in javascipt functions always add a reference to the API documentation.

fsheikh · 2024-12-25T15:32:37Z

client/src/Components/Navbar.jsx

+
+      {/* This is the 1st navbar */}
+      <div className= "bg-green-700}">
+        <div className={`flex bg-green-700 gap-[1150px] ${i18.language === 'ur' ? 'gap-[1130px]' : 'gap-[1150px'}


please fix the syntax error, it also shows that testing is missing

MuhammadTaha01 and others added 28 commits September 23, 2024 23:44

Create and Read functionality has been implemented along with login too

7e3d4a8

Controllers for Search/Read/Post and Get start working

4577cb7

Instructions that how to setup the project has been typed

2bcdad8

Delete cpp directory

8da4b2f

Delete cv directory

9d744a0

Delete doc directory

5328952

Delete unit-test directory

4b8158c

Delete ssa directory

38fdbd8

Delete dsp directory

04ba638

Delete gmb directory

fe2ccc4

Delete itu_2015 directory

7f11afa

Delete lums2016_talk directory

969a78f

Delete musik directory

ef81c3a

Delete deurdu/server/node_modules directory

1fdf932

Server Side chnages migrated to SQLite

be6a6dd

Client folder was added

5c83cfc

Server file was being added

efb6fdd

Stage and commit remaining files

b393b06

Delete client/eslint.config.js

593a305

Delete client/package-lock.json

3d4ed35

Delete client/package.json

b07e773

Delete client/postcss.config.js

8b76ef2

Delete client/vite.config.js

dbe2e06

Delete client/tailwind.config.js

d55d4a2

Update README.md

3836658

Server Readme.md file was updated

4502c10

Delete server/package-lock.json

5a6cfdc

Delete server/package.json

0d4efb4

fsheikh changed the base branch from master to deurdu December 22, 2024 10:30

fsheikh reviewed Dec 22, 2024

View reviewed changes

fsheikh reviewed Dec 23, 2024

View reviewed changes

fsheikh mentioned this pull request Dec 23, 2024

Cleaned up version of #11 #12

Closed

fsheikh reviewed Dec 25, 2024

View reviewed changes

fsheikh mentioned this pull request Jan 4, 2025

Auto-generated code removal and migration to SQLite #13

Merged

		<div className={`flex bg-gray-700 ${i18.language === 'ur' ? 'gap-[775px]' : 'gap-[880px]'}
		${i18.language === 'de' ? 'gap-[700px]' : 'gap-[880px]'}`}>

		This directory contains all data and source code for deurdu blogging
		website.




		export default router; No newline at end of file

Deurdu local #11

Are you sure you want to change the base?

Deurdu local #11

Uh oh!

Conversation

MuhammadTaha01 commented Dec 21, 2024

Uh oh!

fsheikh commented Dec 22, 2024

Uh oh!

fsheikh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fsheikh Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fsheikh Jan 2, 2025 •

edited

Loading