Skip to content

feat: implement gitleaks#43

Merged
loispostula merged 1 commit intomainfrom
infra122-secret-scanning
Aug 31, 2023
Merged

feat: implement gitleaks#43
loispostula merged 1 commit intomainfrom
infra122-secret-scanning

Conversation

@loispostula
Copy link
Member

@loispostula loispostula requested a review from greaka August 30, 2023 16:08
Copy link
Contributor

@greaka greaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to watch out. Github only allows 20 custom workflows in one run, and we are getting close to the limit. So this would probably be one of the first workflows that we will break up eventually.

@loispostula
Copy link
Member Author

Can you point me to the doc stating that limit?

@greaka
Copy link
Contributor

greaka commented Aug 31, 2023

@loispostula
Copy link
Member Author

Ah indeed, I was planning on enabling this workflow through required workflowsd, so it would not be a reusable workflow

@loispostula loispostula merged commit c43a421 into main Aug 31, 2023
@loispostula loispostula deleted the infra122-secret-scanning branch August 31, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants