Skip to content

fix stack overflow when building debug code#1411

Merged
dsyme merged 2 commits intofsprojects:mainfrom
dsyme:so
Nov 17, 2021
Merged

fix stack overflow when building debug code#1411
dsyme merged 2 commits intofsprojects:mainfrom
dsyme:so

Conversation

@dsyme
Copy link
Copy Markdown
Contributor

@dsyme dsyme commented Nov 17, 2021

Fixes #1410, a problem building the debug version of this repo with F# 6.

  1. It turns out Debug build of FSharp.Data.Tests was busted for a while with F# 5 because tailcalls weren't being taken during JSON parsing.
  2. When turning on explicit tailcalls for debug code, the problem went away with F# 5 but remains for F# 6 because of F# 6 takes fewer tailcalls in debug code when explicit /tailcalls+ is specified dotnet/fsharp#12413.
  3. The code changes workaround this

Also adds a debug build to the PRs

@dsyme dsyme merged commit 9dc7353 into fsprojects:main Nov 17, 2021
Numpsy added a commit to Numpsy/Jay that referenced this pull request Aug 24, 2025
…ack overflows

Imports the changes in

fsprojects/FSharp.Data#1225
fsprojects/FSharp.Data#1411

from FSharp.Data, to allow parsing of more deeply nested Json structures without a stack overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stack overflows when compiling FSharp.Data.Tests in debug mode

1 participant