Skip to content

Fix: inference on multiline csv schema#1486

Merged
cartermp merged 3 commits intofsprojects:mainfrom
bongjunj:csv-schema-multiline
May 28, 2023
Merged

Fix: inference on multiline csv schema#1486
cartermp merged 3 commits intofsprojects:mainfrom
bongjunj:csv-schema-multiline

Conversation

@bongjunj
Copy link
Copy Markdown
Contributor

@bongjunj bongjunj commented May 2, 2023

This resolves the point raised at #1483 (comment) by @nightroman

  • Defined a dedicated function to read schema string to break it down into strings, separated by comma, skipping newline characters (CR/LF).
  • Used ResizeArray to build an array of strings, so .Length changed to .Count when used.

Copy link
Copy Markdown
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for delay in review here!

@cartermp cartermp merged commit 5088a47 into fsprojects:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants