Skip to content

[Repo Assist] Make Http.AppendQueryToUrl public#1664

Merged
dsyme merged 2 commits intomainfrom
repo-assist/fix-issue-1325-append-query-to-url-public-a77d7d7711e28325
Feb 26, 2026
Merged

[Repo Assist] Make Http.AppendQueryToUrl public#1664
dsyme merged 2 commits intomainfrom
repo-assist/fix-issue-1325-append-query-to-url-public-a77d7d7711e28325

Conversation

@github-actions
Copy link
Contributor

🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.

Implements the request in #1325 — exposes Http.AppendQueryToUrl as a public API so callers can build query strings with correct percent-encoding without replicating the logic themselves.

Change

Remove the internal modifier from Http.AppendQueryToUrl in Http.fs. The implementation is unchanged; it was already well-tested via its internal use in Http.InnerRequest and WorldBankRuntime.

Usage

open FSharp.Data

let url = Http.AppendQueryToUrl("(api.example.com/redacted), [ "q", "hello world"; "page", "2" ])
// => "(api.example.com/redacted)

// Also handles URLs that already have a query string:
let url2 = Http.AppendQueryToUrl("(api.example.com/redacted), [ "q", "test" ])
// => "(api.example.com/redacted)

Test Status

✅ Build: successful
✅ 5 new unit tests added and passing (AppendQueryToUrl — no params, single param, multiple params, existing query string, special character encoding)
✅ All existing FSharp.Data.Core.Tests pass

Closes #1325

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@f2c5cf1e4af58e09a93ba0703c6bf084711b265f. View source at https://github.com/githubnext/agentics/tree/f2c5cf1e4af58e09a93ba0703c6bf084711b265f/workflows/repo-assist.md.

Remove `internal` modifier from `Http.AppendQueryToUrl` so callers can
use it directly to build query strings without duplicating the escaping
logic.  Five unit tests added.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dsyme dsyme marked this pull request as ready for review February 26, 2026 13:55
@dsyme dsyme merged commit 88b4ceb into main Feb 26, 2026
2 checks passed
@dsyme dsyme deleted the repo-assist/fix-issue-1325-append-query-to-url-public-a77d7d7711e28325 branch February 26, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make AppendQueryToUrl public

1 participant