[Repo Assist] Make Http.AppendQueryToUrl public#1664
Merged
Conversation
Remove `internal` modifier from `Http.AppendQueryToUrl` so callers can use it directly to build query strings without duplicating the escaping logic. Five unit tests added. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
dsyme
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Implements the request in #1325 — exposes
Http.AppendQueryToUrlas a public API so callers can build query strings with correct percent-encoding without replicating the logic themselves.Change
Remove the
internalmodifier fromHttp.AppendQueryToUrlinHttp.fs. The implementation is unchanged; it was already well-tested via its internal use inHttp.InnerRequestandWorldBankRuntime.Usage
Test Status
✅ Build: successful
✅ 5 new unit tests added and passing (
AppendQueryToUrl— no params, single param, multiple params, existing query string, special character encoding)✅ All existing
FSharp.Data.Core.TestspassCloses #1325