Read only metadata section#284
Merged
dsyme merged 6 commits intofsprojects:masterfrom Nov 22, 2018
Merged
Conversation
Contributor
Let's verify this with a real-world solution (cc @blumu) |
Contributor
Author
|
@TIHan I realise now how horrific the previous caching was - comparing full file contents after doing a ReadAllBytes. This PR contains an improvement to at least use GetLastWriteTimeUtc for the comparison and only later call ReadAllBytes if necessary https://github.com/fsprojects/FSharp.TypeProviders.SDK/pull/284/files#diff-7c540ae6a67f14c48d0403e7b021fc86R6646 We sill should move to a non-weak cache though |
Contributor
Author
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change means that only a ByteFile for the metadata section is kept after cracking DLLs in the ILModuleReader used in type providers.
We should also adjust the PEReader so it doesn't read all bytes, so those are ephemeral
Expected benefit is about 50% reduction in memory usage by TPs built using the TPSDK (since referenced assemblies make up most of the memory usage)