CI: merge publish&docs workflow into one#626
Closed
knocte wants to merge 1 commit into
Closed
Conversation
Since both of this workflows get executed only when a git tag is pushed, it's better to make them live in the same file, so that: * They share the same 'on' attribute (there was already an unintended difference between their attributes, caused by a recent change[1]). * They can depend on each other (now the docs job will only be spawned if the publish one succeeded, so that docs are not updated if there was an issue when running the CI for a certain new tag). While at it, I renamed these workflows publish.yml and docs.yml into a new merged one 'tagPush.yml' and renamed the other one for the normal build (buildAndTest.yml) to 'branchPush.yml'. The strategy/matrix elements were also eliminated, since they only make sense in the buildAndTest.yml ones (because we don't want to run the workflow that publishes nuget binaries under different OSs, one is enough). [1] 64f0d53
Collaborator
Author
|
Superseded by #636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since both of this workflows get executed only when a git tag is pushed, it's better to make them live in the same file, so that:
While at it, I renamed these workflows publish.yml and docs.yml into a new merged one 'tagPush.yml' and renamed the other one for the normal build (buildAndTest.yml) to 'branchPush.yml'.
The strategy/matrix elements were also eliminated, since they only make sense in the buildAndTest.yml ones (because we don't want to run the workflow that publishes nuget binaries under different OSs, one is enough).
[1] 64f0d53