Removed workaround in NoPartialFunctions rule
#698
Conversation
knocte
changed the title
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
a1ff3e7 to
db33ff6
Compare
|
Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side. |
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
c9f3bd8 to
ee4ecfb
Compare
Rebased. |
|
Can you move the commit |
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
86442cb to
9e5f360
Compare
Done |
|
@webwarrior-ws could you rebase again and check if you have any changes that cover more cases than mine? |
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
6e5d55e to
e1b5a27
Compare
Rebased (left only the last commit that removes the workaround, since FSharp.Compiler.Service is already newer version in |
|
I’ll make another CI soon |
|
@xperiandri hey thanks for taking over maintainership, I'm the previous maintainer and life was very hectic the past months to even look at my github mail and acknoledge anything. That said can you please make sure CI is a big important part of this project please, we kept refining it in order to make sure that contributions do not break any previous features. Having CI broken constantly since you took over is not acceptable. |
|
@xperiandri bare with me, I just realised that CI got broken 6 months ago! However, IMNSHO the very first thing that should have been done in the repo is fix CI before any other PRs (unrelated to CI) are merged. Please ping me via telegram if you need help (not via email since I'm too busy these days to even look at that), my telegram username is same as my github username. |
And here with "email" I am also referring to github notifications, since they end up in my email too. |
xperiandri
changed the title
NoPartialFunctions rule
xperiandri
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
e1b5a27 to
cf7b5f6
Compare
Remove workaround introduced in [1] for bug in FCS [2] that was fixed in FCS 43.8.200. [1] 106be3f [2] dotnet/fsharp#16121
xperiandri
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
cf7b5f6 to
b916adc
Compare
|
Thank you very much for the contribution! |
Remove workaround introduced in [1] for bug in FCS [2] that was fixed in FCS 43.8.200. [1] webwarrior-ws@106be3f [2] dotnet/fsharp#16121
## [0.25.0] - 2025-07-11 - Migrate from `Paket` to `Directory.Packages.props` #722 [@xperiandri] - Migrate to .NET `9.0.201` and FCS `43.9.201` #722 [@xperiandri] - Write test logs to test context output #722 [@xperiandri] - Use string interpolation instead of `+` concatenation #724 [@xperiandri] - Run tests in parallel #728 [@xperiandri] - Remove `NoPartialFunctions` compiler workaround (#698) [@webwarrior-ws] - Add `SLNX` and `SLNF` format support and migrate to SLNX solution #723 [@xperiandri] Remove `Ionide.ProjInfo.Sln` NuGet package dependency - Remove `Newtonsoft.Json` NuGet dependency #725 [@xperiandri] - Add missing rule checks for FL0079-FL0081 #713 [@BennieCopeland] - Modify `.gitignore` to the Visual Studio standard one #735 [@xperiandri] - Add basic Copilot instructions and GitHub MCP #726 [@xperiandri] - Migrate `Fornax` to `0.16.0-beta002` and `FSharp.Formatting` to `20.0.1` #736 [@xperiandri, @Numpsy] - Update the build instructions to use `dotnet fsi` instead of `fake-cli` #734 [@Numpsy]
3 participants
NoPartialFunctions needed a workaround because of a bug in FSharp.Compiler.Service library.
In FSharp.Compiler.Service to v43.8.200 that has bug has been fixed.
This PR upgrades FCS to v43.8.200 and makes necessary changes to code. Workaround is removed.
Packages FSharp.Core and Ionide.ProjInfo.* also had to be upgraded to latest stable versions.