IndexerAccessorStyleConsistency: new rule #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for indexer accessor style consistency (OCaml and CSharp). Fixes fsprojects#532
After rebasing PR557, these tweaks had to be applied for it to build again, likely because of the recent updates to new versions of FCS dependency.
Add a JSON converter for discriminated unions that only have cases with no fields. It maps DUs to strings, like JsonStringEnumConverter does it for enums. This fixes the tests for IndexerAccessorStyleConsistency rule (for serializing its config simple DU called IndexerAccessorStyle).
knocte
added a commit
to knocte/FSharpLint
that referenced
this pull request
Jan 22, 2026
After we have landed support for serializing simple DUs in [1] (part of [2]), there's no need to have dummy values in the members of these types (in order to force them to be enums). [1] 06ca9c2 [2] fsprojects#794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #557
Fixes #532