Add new rule DiscourageStringInterpolationWithStringFormat #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
As we might change this rule in the future to use |
Fixes: fsprojects#542 Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
knocte
force-pushed
the
FormatString-rebased
branch
6 times, most recently
from
53e1c73 to
eb67825
Compare
That made tests flaky.
Better to not mention "sprintf" in the rule name, in case we
change this rule in the future to recommend inline strings
(e.g. `$"foo{bar}"`).
knocte
force-pushed
the
FormatString-rebased
branch
from
58b062f to
a0ceba8
Compare
knocte
changed the title
Better to place it the last if it's the last added rule.
knocte
force-pushed
the
FormatString-rebased
branch
from
5a660b1 to
f7e8b53
Compare
Make tests more self-contained and less confusing.
knocte
force-pushed
the
FormatString-rebased
branch
from
d424f73 to
1f274b3
Compare
Collaborator
|
@webwarrior-ws I know you contributed to this PR already, but imagine you hadn't: please review the whole diff before I merge. |
webwarrior-ws
commented
Jan 22, 2026
Contributor
Author
|
Other than that, LGTM. |
knocte
force-pushed
the
FormatString-rebased
branch
from
1f274b3 to
27ffeda
Compare
knocte
force-pushed
the
FormatString-rebased
branch
from
27ffeda to
44819e2
Compare
Collaborator
|
@webwarrior-ws actually, I have found a problem, see my last TMP commit. Let's address it with a new commit (adding a test of course). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #542
Supersedes #589