Skip to content

Conversation

@anton-pt
Copy link

@anton-pt anton-pt commented Sep 1, 2015

The previous implementation of Async.AwaitObservable fails for hot observables (which immediately call the OnNext event, potentially multiple times, on subscription). This issue is fixed here by introducing ResultChannel<'T> which can be used to post an result and await it asynchronously elsewhere. Also copied across some unit tests for AwaitObservable from the fsharpx project which are now passing reliably.

… cancellation and hot observables. Added unit tests from old Fsharpx project, some of which failed previously.
…ot observables

Added new class ResultChannel<'T> which can be used to post a
single-fire result and await it asynchronously. Updated
Async.AwaitObservable to use this instead. This implementation also
works for hot observables.
@sideeffffect
Copy link
Contributor

@anton-pt is this code still up-to-date and correct? can I help you with getting this merged?

@anton-pt
Copy link
Author

The

A.

On 24 Sep 2016, at 12:03, Ondra Pelech <notifications@github.commailto:notifications@github.com> wrote:

@anton-pthttps://github.com/anton-pt is this code still up-to-date and correct? can I help you with getting this merged?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/30#issuecomment-249359038, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHp0y3NO45pyApcSnDDI92EhP0IauTOEks5qtQOYgaJpZM4F2Heu.

@anton-pt
Copy link
Author

This contains the implementation that we are now using:
https://github.com/WarwickEPR/Endorphin.Core/blob/master/src/Endorphin.Core.Control.fs

I won't be able to submit a PR with it for at least a month as I don't have a computer at home currently so feel free to copy/modify it and merge it.

Let me know if you can think of any improvements or issues with it.

On 24 Sep 2016, at 12:03, Ondra Pelech <notifications@github.commailto:notifications@github.com> wrote:

@anton-pthttps://github.com/anton-pt is this code still up-to-date and correct? can I help you with getting this merged?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/30#issuecomment-249359038, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHp0y3NO45pyApcSnDDI92EhP0IauTOEks5qtQOYgaJpZM4F2Heu.

@panesofglass
Copy link
Contributor

@sideeffffect or @anton-pt, would either of you be interested in getting this up-to-date and ready to merge?

@panesofglass
Copy link
Contributor

Closing due to age. Please re-open if you would like to help get it up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants