Skip to content

Use latest preview and fix appveyor build#2032

Merged
forki merged 14 commits into
masterfrom
fixbuild
Nov 23, 2016
Merged

Use latest preview and fix appveyor build#2032
forki merged 14 commits into
masterfrom
fixbuild

Conversation

@forki
Copy link
Copy Markdown
Member

@forki forki commented Nov 21, 2016

No description provided.

@forki forki changed the title Use latest preview Use latest preview and fix appveyor build Nov 21, 2016
@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

/cc @enricosada

C:\Users\appveyor\.nuget\packages\fsharp.net.sdk\1.0.0-alpha-000001\build\netstandard1.0\FSharp.NET.Core.Sdk.targets(141,9): error MSB3073: The command "dotnet exec --depsfile C:\Users\appveyor\.nuget\packages\.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json --additionalprobingpath C:\Users\appveyor\.nuget\packages C:\Users\appveyor\.nuget\packages\dotnet-compile-fsc\1.0.0-preview2-020000\lib\netcoreapp1.0\dotnet-compile-fsc.dll @C:\projects\paket\src\Paket.Core\obj\Release\netstandard1.6\dotnet-compile.rsp" exited with code -2147450751. [C:\projects\paket\src\Paket.Core\Paket.Core.preview3.fsproj]

any ideas why that is failing?

@enricosada
Copy link
Copy Markdown
Collaborator

enricosada commented Nov 21, 2016

@forki you are using preview4.
preview4 is in development, so is going to break often.
try to use the released preview3 instead, and pin to 1.0.0-preview3-004056

About why is failing, that's because they changed something and dotnet-compile-fsc doesnt work. I didnt tested f# latest commits of preview4, is going to break sometimes

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

doesn't seem to work

@enricosada
Copy link
Copy Markdown
Collaborator

enricosada commented Nov 21, 2016

ok @forki so, let me see 😄
let's compare with preview3 templates:

C:\projects\paket\dotnetcore\sdk\1.0.0-preview3-004056\NuGet.targets(70,5): warning : Dependency specified was Microsoft.NET.Sdk (>= 1.0.0-alpha-20161029-1) but ended up with Microsoft.NET.Sdk 1.0.0-alpha-20161104-2. [C:\projects\paket\src\Paket.Core\Paket.Core.preview3.fsproj]

if doesnt work after that, i'll clone this pr locally and fix it

also pls remove dev feed (especially the netcorecli-fsc dev feed), for preview3 everything is in nuget.org directly (a lot faster to restore 😄 )

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

now it's completely strange message... urgs

@enricosada
Copy link
Copy Markdown
Collaborator

see https://ci.appveyor.com/project/SteffenForkmann/paket/build/0.0.1.7157#L195

MSBUILD : error MSB4025: The project file could not be loaded. The 'Version' start tag on line 27 position 8 does not match the end tag of 'PackageReference'. Line 29, position 7. [C:\projects\paket\src\Paket\Paket.preview3.fsproj]

@forki you replaced wrongly the xml

<Version>1.0.0-alpha-20161104-2/Version>

the < is missing from </Version>

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

yep. sorry. now we're back to the beginning ;-)

@enricosada
Copy link
Copy Markdown
Collaborator

@forki remove the dev feeds

https://www.myget.org/F/nuget-volatile/api/v3/index.
https://www.myget.org/F/netcorecli-fsc-preview3/api/v3/index.json

preview3 is released, we should use only nuget.org

@enricosada
Copy link
Copy Markdown
Collaborator

anyway i'll try to build this locally tonight, if doesnt work

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

don't think that's it. Paket4 is providing it's own NuGet.Config

@enricosada
Copy link
Copy Markdown
Collaborator

enricosada commented Nov 21, 2016

@forki i think is a bug of my f# integration.

sry locally i cannot repro (i can execute the same command line without errors), but this error

dotnet exec --depsfile C:\Users\appveyor\.nuget\packages\.tools/dotnet-compile-fsc/1.0.0-preview2-020000/netcoreapp1.0/dotnet-compile-fsc.deps.json --additionalprobingpath C:\Users\appveyor\.nuget\packages C:\Users\appveyor\.nuget\packages\dotnet-compile-fsc/1.0.0-preview2-020000/lib/netcoreapp1.0/dotnet-compile-fsc.dll @C:\projects\paket\src\Paket.Core\obj\Release\netstandard1.6\dotnet-compile.rsp
         The specified deps.json [C:\Users\appveyor\.nuget\packages\.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json] does not exist

is the same as the netcorecli-fsc ci server build

I was thinking the missing deps was an xplat issue as reported in dotnet/netcorecli-fsc#41 but is also on windows.
I'll fix that tonight anyway. is a bug

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 21, 2016

Cool. Thanks buddy

Am 21.11.2016 18:56 schrieb "Enrico Sada" notifications@github.com:

@forki https://github.com/forki i think is a bug of my f# integration.

sry locally i cannot repro, but this error
https://ci.appveyor.com/project/SteffenForkmann/paket/build/0.0.1.7164#L275

dotnet exec --depsfile C:\Users\appveyor.nuget\packages.tools/dotnet-compile-fsc/1.0.0-preview2-020000/netcoreapp1.0/dotnet-compile-fsc.deps.json --additionalprobingpath C:\Users\appveyor.nuget\packages C:\Users\appveyor.nuget\packages\dotnet-compile-fsc/1.0.0-preview2-020000/lib/netcoreapp1.0/dotnet-compile-fsc.dll @C:\projects\paket\src\Paket.Core\obj\Release\netstandard1.6\dotnet-compile.rsp
The specified deps.json [C:\Users\appveyor.nuget\packages.tools\dotnet-compile-fsc\1.0.0-preview2-020000\netcoreapp1.0\dotnet-compile-fsc.deps.json] does not exist

is the same as the netcorecli-fsc ci server build
https://ci2.dot.net/job/dotnet_netcorecli-fsc/job/master/job/debug_windows_nt_x86_prtest/7/console

I was thinking the missing deps was an xplat issue as reported in
dotnet/netcorecli-fsc#41
dotnet/netcorecli-fsc#41 but is also on
windows.
I'll fix that tonight anyway. is a bug


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2032 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNAjc9AiZolo3tIAWVRaRSW36C_oUks5rAdtHgaJpZM4K4BPV
.

@enricosada
Copy link
Copy Markdown
Collaborator

enricosada commented Nov 21, 2016

@forki rerun the build pls, i published another FSharp.NET.Sdk package.
pretty sure that works now, i enabled ci on all os for preview3 with dotnet/netcorecli-fsc#45 (dotnet jenkins is really fast)

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 22, 2016

still same issue

@enricosada
Copy link
Copy Markdown
Collaborator

ok, let's stop appveyor driven development so

time for hub checkout https://github.com/fsprojects/Paket/pull/2032 😄

@enricosada
Copy link
Copy Markdown
Collaborator

ok found the issue: it's because you have two fsproj in same directory.

dotnet compile-fsc
Specify which project file to use because this 'e:\github\Paket\src\Paket.Core' contains more than one project file.

it's because i use dotnet compile-fsc , but dotnet find two fsproj in same directory ( Paket.Core.fsproj and Paket.Core.preview3.fsproj ) and doesnt know which one to use for tool dotnet-compile-fsc

i'll try to fix it

@enricosada
Copy link
Copy Markdown
Collaborator

nope, added dotnet/netcorecli-fsc#47 as bug. Good catch @forki !

@forki i send a pr #2036 to fix the build with a workaround. that's my only idea to move forward now.
locally build ok.

@enricosada
Copy link
Copy Markdown
Collaborator

@forki i added some info about how to fix the build failure after my pr is merged, it's a problem with FAKE script, see #2036 (comment)

i think is enough to Environment.SetEnvironmentVariable of current process.

@forki forki merged commit 51754f2 into master Nov 23, 2016
@forki forki deleted the fixbuild branch November 23, 2016 09:13
@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 23, 2016

thanks. next step would be to make it work on travis. and the dotnet pack stuff

@enricosada
Copy link
Copy Markdown
Collaborator

@forki yes, i think the install of sdk if wrong on travis.

Installing 'https://dotnetcli.blob.core.windows.net/dotnet/Sdk/1.0.0-preview3-004056/dotnet-dev-win-x64.1.0.0-preview3-004056.zip' to '/home/travis/build/fsprojects/Paket/dotnetcore/dotnet-dev-win-x64.1.0.0-preview3-004056.zip

that's the url for windows. try dotnet-dev-ubuntu.14.04-x64.#{dotnet_version}.tar.gz

@enricosada
Copy link
Copy Markdown
Collaborator

@forki about pack just try it (appveyor driven dev 😄 ), if doesnt work i'll fix that but should work ok if project is netcore only.

@mchuck
Copy link
Copy Markdown

mchuck commented Nov 23, 2016

@enricosada The current code in build.fsx will not unpack tar.gz file:

System.IO.Compression.ZipFile.ExtractToDirectory(localPath, dotnetCliPath.FullName)

@enricosada
Copy link
Copy Markdown
Collaborator

good catch @Alaiven

lets invoke tar xf meanwhile as workaround? like in suave https://github.com/SuaveIO/suave/blob/956af39393e7dfe2cf5288fb352098c802b09cf9/Rakefile#L119-L139

@forki
Copy link
Copy Markdown
Member Author

forki commented Nov 23, 2016

@Alaiven can you please end a PR? thanks

@mchuck
Copy link
Copy Markdown

mchuck commented Nov 23, 2016

@forki What do you mean? I'm new to github

@enricosada
Copy link
Copy Markdown
Collaborator

@Alaiven he is asking if you want to contribute making the fix yourself, and send as pull request so can be included in this project.
Basically fork this repository, create a branch with the changes to fix the issue and create a pull request. see https://guides.github.com/activities/forking/
if you need help just join the paket chat on gitter for helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants