Skip to content

Comments

fix: node_md_disks state label as failed#1

Merged
fsschmitt merged 1 commit intomasterfrom
fix/alerts-label-naming
Feb 10, 2021
Merged

fix: node_md_disks state label as failed#1
fsschmitt merged 1 commit intomasterfrom
fix/alerts-label-naming

Conversation

@fsschmitt
Copy link
Owner

@fsschmitt fsschmitt commented Oct 7, 2020

This PR is a mirror of the remote: prometheus#1862

Within node_exporter the metric node_md_disks exports the following states:

  • Active
  • Failed
  • Spare

In the meantime, on the jsonnet alerts it was using the label state="fail" instead of state="failed".

This pull request fixes that issue.


Additional information

This information can be also confirmed on:

ch <- prometheus.MustNewConstMetric(
  disksDesc,
  prometheus.GaugeValue,
  float64(mdStat.DisksFailed),
  mdStat.Name,
  "failed",
)
# HELP node_md_disks Number of active/failed/spare disks of device.
# TYPE node_md_disks gauge
node_md_disks{device="md0",state="active"} 2
node_md_disks{device="md0",state="failed"} 0
node_md_disks{device="md0",state="spare"} 0

Signed-off-by: fsschmitt <492108+fsschmitt@users.noreply.github.com>
@fsschmitt fsschmitt self-assigned this Oct 7, 2020
@fsschmitt fsschmitt merged commit a418ff3 into master Feb 10, 2021
@fsschmitt fsschmitt deleted the fix/alerts-label-naming branch February 10, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant