Make special exception in referenceFS #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we distinguish between files not in the reference list and anything that goes wrong during the fetch.
This was referenced Nov 21, 2022
joshmoore
reviewed
Nov 22, 2022
| cause issues or regressions for either other fsspec-related packages such | ||
| as gcsfs and s3fs, nor for downstream users of fsspec. The "downstream" CI | ||
| run and corresponding environment file run a set of tests from the dask | ||
| test suite, and very minimal tests against pandas and zarr from the test_dowstream.py |
Contributor
There was a problem hiding this comment.
Bit late, but "test_downstream.py"? But otherwise, ❤️ for this.
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
👍 I just meant the spelling in the README. Sorry, no excuse not to have opened a PR: #1121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we distinguish between files not in the reference list and anything that goes wrong during the fetch.
Enables zarr-developers/zarr-python#1237 and fixes fsspec/kerchunk#253
Added CI move away from tox and onto mamba