Skip to content

upath.implementations.cloud: move empty bucket checks to subclasses #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ap-- merged 1 commit into from
Sep 8, 2024
Merged

upath.implementations.cloud: move empty bucket checks to subclasses #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions upath/implementations/cloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@
class CloudPath(UPath):
__slots__ = ()

def __init__(
self, *args, protocol: str | None = None, **storage_options: Any
) -> None:
super().__init__(*args, protocol=protocol, **storage_options)
if not self.drive and len(self.parts) > 1:
raise ValueError("non key-like path provided (bucket/container missing)")

@classmethod
def _transform_init_args(
cls,
Expand Down Expand Up @@ -71,6 +64,13 @@ def relative_to(self, other, /, *_deprecated, walk_up=False):
class GCSPath(CloudPath):
__slots__ = ()

def __init__(
self, *args, protocol: str | None = None, **storage_options: Any
) -> None:
super().__init__(*args, protocol=protocol, **storage_options)
if not self.drive and len(self.parts) > 1:
raise ValueError("non key-like path provided (bucket/container missing)")

def mkdir(
self, mode: int = 0o777, parents: bool = False, exist_ok: bool = False
) -> None:
Expand All @@ -84,6 +84,20 @@ def mkdir(
class S3Path(CloudPath):
__slots__ = ()

def __init__(
self, *args, protocol: str | None = None, **storage_options: Any
) -> None:
super().__init__(*args, protocol=protocol, **storage_options)
if not self.drive and len(self.parts) > 1:
raise ValueError("non key-like path provided (bucket/container missing)")


class AzurePath(CloudPath):
__slots__ = ()

def __init__(
self, *args, protocol: str | None = None, **storage_options: Any
) -> None:
super().__init__(*args, protocol=protocol, **storage_options)
if not self.drive and len(self.parts) > 1:
raise ValueError("non key-like path provided (bucket/container missing)")