Skip to content

Conversation

@AbelGAlem
Copy link

Description

  • The current test verifies deletion by checking that the deleted note’s content is no longer present.
  • content is not guaranteed to be unique, so the test can produce false positives/negatives if multiple notes share identical content.

@vejol
Copy link
Contributor

vejol commented Jan 3, 2026

Thank you for the pull request! There are a few issues that should be fixed before it can be accepted.

The findByIdAndUpdate method is not suitable for the use case in Part 3. A short note about this was added to Part 3 in November 2025. The Part 3 related changes should be removed from this pull request.

Using the id in the test in Part 4 is a good idea. However, this change should also be applied to the other relevant places. In Part 4b, there also seems to be another spot where the same lines of code are shown.

@vejol vejol added the part 4 label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants