Replaces duplicate promises with original promises in the queue #9
Merged
paras-fundwave merged 19 commits intomainfrom Nov 20, 2024
Merged
Replaces duplicate promises with original promises in the queue #9paras-fundwave merged 19 commits intomainfrom
paras-fundwave merged 19 commits intomainfrom
Conversation
- refactor queue datatype to map
fix: original fetch requests not resolving
rickygarg
reviewed
Nov 13, 2024
rickygarg
reviewed
Nov 13, 2024
…parameters provided - chore: update eslintrc to allow types to be set as any
rickygarg
reviewed
Nov 14, 2024
rickygarg
reviewed
Nov 14, 2024
rickygarg
reviewed
Nov 14, 2024
rickygarg
reviewed
Nov 14, 2024
rickygarg
reviewed
Nov 20, 2024
paras-fundwave
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoiding duplicate fetch calls (with same URL and payload) by replacing duplicate promise with original promise in the queue
ArraytoMapwith key as stringified JSON of URL, payload and method of the fetch call.Resolutions
fetchpromise to the originalfetchpromise #10Depends on
NA
Deployment
Current pipelines will suffice