Merge master into dev + fixes.#53
Conversation
Set reset variable based on script. Removed some unneeded demo specific vars. Added source of my_vars for user specific variables.
* Add prompts for dockerhub credentials, make my_vars file optional, add support for arbitrary ansible arguments when executing local setup * update reset_environmnent, add support for my_vars.yml
This reverts commit 3c7e187.
|
I've tested linux and ec2. If someone could look/test out mac, that would be very helpful. |
|
Ran on mac and saw an issue: TASK [ansible_service_broker_setup : set_fact] ************************************************************************************************************************ TASK [ansible_service_broker_setup : uri] ***************************************************************************************************************************** PLAY RECAP ************************************************************************************************************************************************************ real 4m30.898s Yet when I try the route it looks good: $ curl -X POST http://asb-1338-ansible-service-broker.192.168.37.1.nip.io/v2/bootstrap I will debug more on my end, but might not have the time till Friday. |
|
Retested today and had success. Ran through the postgres + python webapp demo on macOS with this PR. |
jwmatthews
left a comment
There was a problem hiding this comment.
Looks good, had success.
Thanks Chris for doing this.
|
ACK |
Merged in master to dev branch and reverted commit that uses summit code.