Integrate templates into the playbooks#6
Closed
rthallisey wants to merge 1 commit into
Closed
Conversation
Instead of using asbcli to create the broker, use templates and render them with jinja2.
Member
|
Current thoughts are to hold off on merging this till post demo. Then to rework the ASB build/deploy inline with this PR. |
Contributor
|
Reapply this PR against the dev branch please. |
jmrodri
requested changes
May 16, 2017
Contributor
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
reapply against the dev branch
Contributor
|
@rthallisey @jmrodri @jwmatthews is this still desired for the dev branch? |
Contributor
Author
|
I haven't had a change to move to the dev branch yet, but it will re use the templates as a way to deploy the broker. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using asbcli to create the broker, use templates and render them with jinja2.
I tested this by hooking asbcli up to it, not the service catalog. I'll do the full e2e test with the catalog tomorrow.
The ansibleplaybookbundle broker image was not working, but the ansibleapp broker images was. I'm assuming that image was under development when I pulled it. I'll do testing with the ansibleplaybookbundle broker image again tomorrow.